Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat]: add uppercase processor #41535

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

khushijain21
Copy link
Contributor

Proposed commit message

This PR implements uppercase processor using alterFieldProcessor. Closes #22254

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@khushijain21 khushijain21 requested a review from a team as a code owner November 6, 2024 14:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 6, 2024
@khushijain21 khushijain21 requested a review from rdner November 6, 2024 14:18
Copy link
Contributor

mergify bot commented Nov 6, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 6, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 6, 2024
@@ -59,32 +59,6 @@ func TestLowerCaseProcessorRun(t *testing.T) {
Output mapstr.M
Error bool
}{
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate test case

@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 6, 2024
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@khushijain21 khushijain21 merged commit 92ed683 into elastic:main Nov 7, 2024
142 checks passed
mergify bot pushed a commit that referenced this pull request Nov 7, 2024
* [libbeat]: add uppercase processor

* add PR number in changelog

(cherry picked from commit 92ed683)
pierrehilbert pushed a commit that referenced this pull request Nov 7, 2024
* [libbeat]: add uppercase processor

* add PR number in changelog

(cherry picked from commit 92ed683)

Co-authored-by: Khushi Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat Processors - make uppercase and lowercase processors (as in ES ingest nodes) available to filebeat
3 participants