Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat Processors - make uppercase and lowercase processors (as in ES ingest nodes) available to filebeat #22254

Closed
ccmsi opened this issue Oct 29, 2020 · 31 comments · Fixed by #41535
Assignees
Labels
discuss Issue needs further discussion. enhancement good first issue Indicates a good issue for first-time contributors Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@ccmsi
Copy link

ccmsi commented Oct 29, 2020

Greetings and thanks for this software.

I would like to request for adding the two processors uppercase and lowercase to filebeat input processing.

Besides being useful, adds to making things consistent.

Thanks for your time and attention

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 29, 2020
@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Oct 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 29, 2020
@andresrc
Copy link
Contributor

andresrc commented Nov 3, 2020

We are encouraging the use of ingest-node processors. What's the driving use case to have them available in the beats themselves?

@ccmsi
Copy link
Author

ccmsi commented Nov 4, 2020

The question seems like asking about personal taste. And as there are 2 options that's in a way how it is.

However, its filebeat that offers that option to begin with. There are processors. So one question in return is, why then does it exist if that is your question? IMO filebeat team by implementing processors has already expressed that interest for it to be there and as such this question seems awkward.

For support, i appreciate the decision of the filebeat team to provide processors. I think central management is nice, but distributing load is advantageous performance wise and offers flexibility. Changes are easier to work on while reducing risk.

My request though is about why not having those two simple ones, where the more complex ones, even script, are available.

@trnl
Copy link

trnl commented Nov 5, 2020

I would double that.

Now we have hideous rename block with a lot of boilerplate because of casing:

          - from: header.x-request-id
            to: x-request-id
          - from: headers.x-request-id
            to: x-request-id
          - from: headers.X-Request-ID
            to: x-request-id
          - from: headers.X-Request-Id
            to: x-request-id
          - from: headers.X-request-Id
            to: x-request-id

@andresrc andresrc added discuss Issue needs further discussion. enhancement good first issue Indicates a good issue for first-time contributors labels Dec 15, 2020
@bduffy-aylien
Copy link

bduffy-aylien commented Apr 13, 2021

Hi, lower and upper case processors would be nice. You can achieve something similar just using the script processor. For example I have a field for log level and I can set it to lowercase like so;

        -
          script:
            lang: javascript
            id: lowercase
            source: >
              function process(event) {
                  var level = event.Get("level");
                  if(level != null) {
                      event.Put("level", level.toString().toLowerCase());
                  }
              }

@lplazas
Copy link

lplazas commented Jul 2, 2021

If no one is working on this one I'd like to give it a go as my first issue in this repo

@mr1716
Copy link
Contributor

mr1716 commented Jan 21, 2022

Hey, how is this progressing?? Is there any sense of a release date for adding the uppercase and lowercase processors in a filebeat release?

@jlind23 jlind23 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 31, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@sqall01
Copy link

sqall01 commented Apr 12, 2022

I would also like to know the state of this issue.

We need case-insensitive filtering on Winlogbeat (without using regex). And this processor would allow us to build it.

@mr1716
Copy link
Contributor

mr1716 commented May 4, 2022

@sqall01 there is the potential to use the script processor and the Javascript toLowerCase and toUpperCase to do this, but this requires looping through the desired values, deleting the old values, and then replacing with the new values. So having this done by a processor would be really helpful! Maybe this is something that elastic can build in for us?

@sqall01
Copy link

sqall01 commented May 4, 2022

@mr1716 yes the script processor would be a possibility. However, we have to do this for a lot of events that we filtering and I have concerns regarding the performance if we always go through Javascript for this.

@mr1716
Copy link
Contributor

mr1716 commented May 4, 2022

@sqall01 agreed. Just throwing it out there as an option, even though it isnt equivalent

@mr1716
Copy link
Contributor

mr1716 commented May 5, 2022

@lplazas How is development going?? May you please provide an update?

@mr1716
Copy link
Contributor

mr1716 commented May 11, 2022

@jlind23 Any possibility to get some engineers to assist with this development?

@jlind23
Copy link
Collaborator

jlind23 commented May 11, 2022

@mr1716 this is something that should go through our prioritisation first, for now we do not have someone to work on it.

@mr1716
Copy link
Contributor

mr1716 commented May 11, 2022

@jlind23 how would that take place and are there actions that the community would need to do?

@jlind23
Copy link
Collaborator

jlind23 commented May 18, 2022

@mr1716 The only thing I can think of right now is that this is something you can work on if you need and i'll find someone to review and assist.

@mr1716
Copy link
Contributor

mr1716 commented May 18, 2022

@jlind23 Ok. I'll see if there is time, but there looks to be the need. I have a way to do it in Javascript, so maybe the employee can take what I have and convert it to something that can be converted into Filebeat?

@jlind23
Copy link
Collaborator

jlind23 commented May 19, 2022

@mr1716 it will still imply too much time availability on their end. I will discuss with @nimarezainia on it first.

@mr1716
Copy link
Contributor

mr1716 commented Sep 22, 2022

@jlind23 hey, hope all is well. IS there any progress or update to provide?

@jlind23
Copy link
Collaborator

jlind23 commented Sep 23, 2022

@mr1716 nothing occurred as we were focused on other areas. Let me add it to @nimarezainia and @pierrehilbert's plate for awareness and prioritization.

@hartfordfive
Copy link
Contributor

Is there a plan yet to implement this feature in the near future?

@zez3
Copy link

zez3 commented Oct 4, 2022

I think there are some discussions but nothing concrete
https://github.com/elastic/ingest-dev/issues/2442

@zez3
Copy link

zez3 commented Oct 4, 2022

and this elastic/elastic-package#949 (comment)
"we will try and pursiue the correct implementation in 8.7 (once prioritized amongst other asks there)"

@mr1716
Copy link
Contributor

mr1716 commented Oct 4, 2022

@zez3 thanks for this. So this means that there will be the implementation at some point, which is great!

@davidifr
Copy link
Contributor

Hi @jlind23 ,
Is this issue still open for takers? or is it still on discussion?

@mr1716
Copy link
Contributor

mr1716 commented Dec 11, 2022

@davidifr I think it's open for anyone to take

@jlind23
Copy link
Collaborator

jlind23 commented Dec 12, 2022

Hi @davidifr, as @mr1716 said you can take it and we will have someone reviewing the work you can do 👍🏼

@botelastic
Copy link

botelastic bot commented Sep 20, 2024

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 20, 2024
@zez3
Copy link

zez3 commented Sep 20, 2024

Not stale, still needed

@botelastic botelastic bot removed the Stalled label Sep 20, 2024
@zez3
Copy link

zez3 commented Sep 20, 2024

I think @davidifr is no longer an active account. It would be nice of someone would take over and finish this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. enhancement good first issue Indicates a good issue for first-time contributors Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet