-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mage installation with go1.18 #33083
fix: mage installation with go1.18 #33083
Conversation
This pull request doesn't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I noticed this errors in the logs but never got around to figuring out why they were there.
I'm still fixing it ... $ docker run --rm -ti -v `pwd`:/src/github.com/elastic/beats -w /src/github.com/elastic/beats ubuntu
$ apt-get update ; apt-get install -y curl make build-essential ; HOME=/src ./dev-tools/run_with_go_ver make test-mage
+ /src/bin/gvm 1.17.10
+ cut -d ' ' -f 2
+ tr -d '\"'
++ /src/bin/gvm 1.17.10
+ eval 'export GOROOT="/src/.gvm/versions/go1.17.10.linux.amd64"
export PATH="/src/.gvm/versions/go1.17.10.linux.amd64/bin:$PATH"'
++ export GOROOT=/src/.gvm/versions/go1.17.10.linux.amd64
++ GOROOT=/src/.gvm/versions/go1.17.10.linux.amd64
++ export PATH=/src/.gvm/versions/go1.17.10.linux.amd64/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++ PATH=/src/.gvm/versions/go1.17.10.linux.amd64/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
...
## Functions
beat_doc_branch = {{ beat_doc_branch }}
beat_version = {{ beat_version }}
commit = {{ commit }}
date = {{ date }}
elastic_beats_dir = {{ elastic_beats_dir }}
go_version = {{ go_version }}
repo.RootImportPath = {{ repo.RootImportPath }}
repo.CanonicalRootImportPath = {{ repo.CanonicalRootImportPath }}
repo.RootDir = {{ repo.RootDir }} |
dir("${BASE_DIR}") { | ||
sh "HOME=${WORKSPACE} GO_VERSION=${GO_VERSION} ./dev-tools/run_with_go_ver make test-mage" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmacknz , I think this will be ready to be merged, somehow my initial thoughts were about the GOPATH, but the issue was related to |
@Mergifyio backport main |
@Mergifyio backport 8.5 |
@Mergifyio backport 8.4 |
✅ Backports have been created
|
❌ No backport have been created
|
* path for the mage with go1.18 has changed * ci: test the command in the CI pipeline * ci: set HOME * new make goal to validate the mage installation * unrequired path when using go install (cherry picked from commit 5385fd2) # Conflicts: # Jenkinsfile
* path for the mage with go1.18 has changed * ci: test the command in the CI pipeline * ci: set HOME * new make goal to validate the mage installation * unrequired path when using go install (cherry picked from commit 5385fd2) # Conflicts: # Jenkinsfile
✅ Backports have been created
|
@Mergifyio backport 8.5 |
* path for the mage with go1.18 has changed * ci: test the command in the CI pipeline * ci: set HOME * new make goal to validate the mage installation * unrequired path when using go install (cherry picked from commit 5385fd2) # Conflicts: # Jenkinsfile
✅ Backports have been created
|
What does this PR do?
go1.18 changed where the packages are installed when using
go install
Run the same command in the CI pipeline
Why is it important?
The UR for 7.17 is broken for the last 5 days.
Test
Additionally, I tested on docker, to be the more platform agnostic as possible, see #33083 (comment)
Issues
Caused by #32693