Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mage installation with go1.18 (backport #33083) #33159

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 21, 2022

This is an automatic backport of pull request #33083 done by Mergify.
Cherry-pick of 5385fd2 has failed:

On branch mergify/bp/8.5/pr-33083
Your branch is up to date with 'origin/8.5'.

You are currently cherry-picking commit 5385fd2387.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Makefile
	modified:   dev-tools/make/mage-install.mk

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Jenkinsfile

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* path for the mage with go1.18 has changed

* ci: test the command in the CI pipeline

* ci: set HOME

* new make goal to validate the mage installation

* unrequired path when using go install

(cherry picked from commit 5385fd2)

# Conflicts:
#	Jenkinsfile
@mergify mergify bot requested a review from a team as a code owner September 21, 2022 18:35
@mergify mergify bot requested review from faec and leehinman and removed request for a team September 21, 2022 18:35
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Sep 21, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2022
@botelastic
Copy link

botelastic bot commented Sep 21, 2022

This pull request doesn't have a Team:<team> label.

@botelastic
Copy link

botelastic bot commented Nov 20, 2022

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 20, 2022
@botelastic
Copy link

botelastic bot commented Dec 20, 2022

Hi!
This PR has been stale for a while and we're going to close it as part of our cleanup procedure.
We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team.
Feel free to re-open this PR if you think it should stay open and is worth rebasing.
Thank you for your contribution!

@botelastic botelastic bot closed this Dec 20, 2022
@mergify mergify bot deleted the mergify/bp/8.5/pr-33083 branch December 20, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label Stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant