Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mage installation with go1.18 (backport #33083) #33150

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 21, 2022

This is an automatic backport of pull request #33083 done by Mergify.
Cherry-pick of 5385fd2 has failed:

On branch mergify/bp/8.4/pr-33083
Your branch is up to date with 'origin/8.4'.

You are currently cherry-picking commit 5385fd2387.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Makefile
	modified:   dev-tools/make/mage-install.mk

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Jenkinsfile

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* path for the mage with go1.18 has changed

* ci: test the command in the CI pipeline

* ci: set HOME

* new make goal to validate the mage installation

* unrequired path when using go install

(cherry picked from commit 5385fd2)

# Conflicts:
#	Jenkinsfile
@mergify mergify bot requested a review from a team as a code owner September 21, 2022 15:23
@mergify mergify bot requested review from cmacknz and fearful-symmetry and removed request for a team September 21, 2022 15:23
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Sep 21, 2022
@botelastic botelastic bot added Team:Automation Label for the Observability productivity team needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 21, 2022
Jenkinsfile Outdated Show resolved Hide resolved
@v1v v1v self-assigned this Sep 21, 2022
@v1v v1v removed the conflicts There is a conflict in the backported pull request label Sep 21, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-21T15:25:41.170+0000

  • Duration: 94 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 22711
Skipped 1947
Total 24658

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v merged commit b2bbdbb into 8.4 Sep 21, 2022
@v1v v1v deleted the mergify/bp/8.4/pr-33083 branch September 21, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants