-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbeat/common/transport: fix log message about TLS #30331
Conversation
This pull request does not have a backport label. Could you fix it @belimawr? 🙏
NOTE: |
/test |
This commit fixes the log message issued by the `test output` command. Our current TLS verification relies on more than the value of `tlsConfig.InsecureSkipVerify`, so the previous implementation would log that TLS was disabled when it was not. This commit fixes it by checking the value of `config.Verification`.
8d62a4b
to
77de590
Compare
rebase onto main, force-push |
/test |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Did we sanity check this on Windows 10 specifically to ensure the issue with the original change is fixed? |
The issue wasn't Windows-specific, I believe some Windows tests triggered it first or they have a different test suit that triggered the bug. |
Anyway, I'll try to test it on Windows before merging this PR. |
This commit fixes the log message issued by the `test output` command. Our current TLS verification relies on more than the value of `tlsConfig.InsecureSkipVerify`, so the previous implementation would log that TLS was disabled when it was not. This commit fixes it by checking the value of `config.Verification`. (cherry picked from commit 4eeb5a9)
…ut TLS (#32909) This commit fixes the log message issued by the `test output` command. Our current TLS verification relies on more than the value of `tlsConfig.InsecureSkipVerify`, so the previous implementation would log that TLS was disabled when it was not. This commit fixes it by checking the value of `config.Verification`. (cherry picked from commit 4eeb5a9) Co-authored-by: Tiago Queiroz <[email protected]>
What does this PR do?
This commit fixes the log message issued by the
test output
command.Our current TLS verification relies on more than the value of
tlsConfig.InsecureSkipVerify
, so the previous implementation wouldlog that TLS was disabled when it was not.
This commit fixes it by checking the value of
config.Verification
.Why is it important?
It fixes a logging issue
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
Agent [master]: dev, snapshot build crashes on start on Windows #30315
Missing TLS configuration causes agent crash on Windows #30314
How to test this PR locally
To test using Filebeat, set the
ssl.verification_mode
on any Beat output to anything other thannone
, then runfilebeat test output
. You should see the correct log message based on the verification mode you set.Related issues
## Use cases## ScreenshotsLogs