Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17](backport #30063) libbeat/common/transport: fix log message about TLS #30301

Closed
wants to merge 2 commits into from
Closed

[7.17](backport #30063) libbeat/common/transport: fix log message about TLS #30301

wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 9, 2022 •
edited by zube bot
Loading

This is an automatic backport of pull request #30063 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@belimawr
libbeat/common/transport: fix log message about TLS (#30063)
293814d 
This commit fixes the log message issued by the `test output` command.
Our current TLS verification relies on more than the value of
`tlsConfig.InsecureSkipVerify`, so the previous implementation would
log that TLS was disabled when it was not.

This commit fixes it by checking the value of `config.Verification`.

Co-authored-by: Craig MacKenzie <[email protected]>
(cherry picked from commit e208c22)
@mergify mergify bot added the backport label Feb 9, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 9, 2022
@botelastic
Copy link

botelastic bot commented Feb 9, 2022

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 9, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-09T19:21:05.416+0000

  • Duration: 125 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 55245
Skipped 5322
Total 60567

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cmacknz
cmacknz requested changes Feb 9, 2022
View reviewed changes
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until #30315 is resolved.

@cmacknz cmacknz mentioned this pull request Feb 9, 2022
Closed
@mergify
Copy link
Contributor Author

mergify bot commented Feb 11, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/7.17/pr-30063 upstream/mergify/bp/7.17/pr-30063
git merge upstream/7.17
git push upstream mergify/bp/7.17/pr-30063

@belimawr
Copy link
Contributor

Closing this because of it's bug. Next week I'll backport the fixed version that's been merged on main: #30331

@belimawr belimawr closed this Feb 11, 2022
@mergify mergify bot deleted the mergify/bp/7.17/pr-30063 branch February 11, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz requested changes

Assignees

@belimawr belimawr

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @belimawr @cmacknz