-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17](backport #30331) libbeat/common/transport: fix log message about TLS #32909
Conversation
This commit fixes the log message issued by the `test output` command. Our current TLS verification relies on more than the value of `tlsConfig.InsecureSkipVerify`, so the previous implementation would log that TLS was disabled when it was not. This commit fixes it by checking the value of `config.Verification`. (cherry picked from commit 4eeb5a9)
This pull request doesn't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good, code is the same as the original change.
Yes, it is. But the original fix had some issues, so I rather have a second pair of eyes, also this helps to bring visibility this is being merged. Now let me try to get CI happy before merging it... |
🤔 |
/test |
This is an automatic backport of pull request #30331 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com