Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #30331) libbeat/common/transport: fix log message about TLS #32909

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 29, 2022

This is an automatic backport of pull request #30331 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This commit fixes the log message issued by the `test output` command.
Our current TLS verification relies on more than the value of
`tlsConfig.InsecureSkipVerify`, so the previous implementation would
log that TLS was disabled when it was not.

This commit fixes it by checking the value of `config.Verification`.

(cherry picked from commit 4eeb5a9)
@mergify mergify bot requested a review from a team as a code owner August 29, 2022 13:22
@mergify mergify bot requested review from belimawr and fearful-symmetry and removed request for a team August 29, 2022 13:22
@mergify mergify bot added the backport label Aug 29, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 29, 2022
@botelastic
Copy link

botelastic bot commented Aug 29, 2022

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-30T07:09:25.583+0000

  • Duration: 41 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 584
Skipped 144
Total 728

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good, code is the same as the original change.

@belimawr
Copy link
Contributor

Still looks good, code is the same as the original change.

Yes, it is. But the original fix had some issues, so I rather have a second pair of eyes, also this helps to bring visibility this is being merged.

Now let me try to get CI happy before merging it...

@belimawr
Copy link
Contributor

Service 'jolokia' failed to build: manifest for java:8-jdk-alpine not found: manifest unknown: manifest unknown

🤔

@belimawr
Copy link
Contributor

/test

@belimawr belimawr merged commit 37a52cf into 7.17 Aug 30, 2022
@belimawr belimawr deleted the mergify/bp/7.17/pr-30331 branch August 30, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants