Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rum-core): use startTime for LCP marks #815

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

vigneshshanmugam
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

Merging #815 into master will decrease coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   93.37%   93.05%   -0.33%     
==========================================
  Files          50       50              
  Lines        2445     2303     -142     
  Branches      516      460      -56     
==========================================
- Hits         2283     2143     -140     
+ Misses        159      157       -2     
  Partials        3        3              
Impacted Files Coverage Δ
...ges/rum-core/src/performance-monitoring/metrics.js 89.53% <100.00%> (-2.84%) ⬇️
.../src/performance-monitoring/transaction-service.js 90.69% <0.00%> (-2.99%) ⬇️

@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #815 opened]

  • Start Time: 2020-06-15T13:29:28.924+0000

  • Duration: 77 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 938
Skipped 10
Total 948

Steps errors

Expand to view the steps failures

  • Name: Bundlesize
    • Description: #!/bin/bash set -o pipefail npm run bundlesize|tee bundlesize.txt

    • Duration: 1 min 39 sec

    • Start Time: 2020-06-15T13:36:10.647+0000

    • log

@vigneshshanmugam vigneshshanmugam merged commit 7ee82da into elastic:master Jun 15, 2020
@vigneshshanmugam vigneshshanmugam deleted the use-starttime branch June 15, 2020 14:56
v1v added a commit to v1v/apm-agent-rum-js that referenced this pull request Jul 3, 2020
* upstream/master: (23 commits)
  feat(rum-core): capture XHR/Fetch spans using resource timing (elastic#825)
  docs: update set-up.asciidoc (elastic#814)
  chore: remove compressed size gh workflow (elastic#828)
  feat: use page visibilityState for browser responsiveness check (elastic#813)
  ci(jenkins): report bundlesize as a GitHub comment (elastic#826)
  docs: release notes for 5.2.1 (elastic#824)
  chore(release): publish
  fix(rum-core): protect aganist buggy navigation timing data (elastic#819)
  fix(rum-core): protect aganist buggy navigation timing data (elastic#819)
  chore(rum-core): use startTime for LCP marks (elastic#815)
  fix(rum-core): capture tbt after all task entries are observed (elastic#803)
  feat(rum-react): use correct path when route is path array (elastic#800)
  ci: enable benchmark on a PR basis (elastic#812)
  ci: use dockerLogs step (elastic#810)
  fix: env var invalid type (elastic#809)
  fix: workarount for elastic/beats#18858 (elastic#807)
  docs: add release notes for 5.2.0 (elastic#801)
  chore(release): publish
  fix(rum-core): consider user defined type of high precedence (elastic#798)
  fix(rum): use single instance of apm across all packages (elastic#796)
  ...
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants