Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set-up.asciidoc #814

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Update set-up.asciidoc #814

merged 2 commits into from
Jun 30, 2020

Conversation

christianhaller3000
Copy link
Contributor

I think it should be in quotes

I think it should be in quotes
@cla-checker-service
Copy link

cla-checker-service bot commented Jun 11, 2020

💚 CLA has been signed

@apmmachine
Copy link
Contributor

apmmachine commented Jun 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Vignesh Shanmugam, Replayed #7]

  • Start Time: 2020-06-30T15:12:42.466+0000

  • Duration: 9 min 42 sec

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to

'process.env.NODE_ENV': JSON.stringify('production')

as it is better than having quotes around.

@vigneshshanmugam
Copy link
Member

@christianhaller3000 Could you please sign the CLA https://www.elastic.co/contributor-agreement so i can get this in.

@christianhaller3000
Copy link
Contributor Author

@vigneshshanmugam I did that. But I never received an email.

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshshanmugam vigneshshanmugam merged commit c880382 into elastic:master Jun 30, 2020
v1v added a commit to v1v/apm-agent-rum-js that referenced this pull request Jul 3, 2020
* upstream/master: (23 commits)
  feat(rum-core): capture XHR/Fetch spans using resource timing (elastic#825)
  docs: update set-up.asciidoc (elastic#814)
  chore: remove compressed size gh workflow (elastic#828)
  feat: use page visibilityState for browser responsiveness check (elastic#813)
  ci(jenkins): report bundlesize as a GitHub comment (elastic#826)
  docs: release notes for 5.2.1 (elastic#824)
  chore(release): publish
  fix(rum-core): protect aganist buggy navigation timing data (elastic#819)
  fix(rum-core): protect aganist buggy navigation timing data (elastic#819)
  chore(rum-core): use startTime for LCP marks (elastic#815)
  fix(rum-core): capture tbt after all task entries are observed (elastic#803)
  feat(rum-react): use correct path when route is path array (elastic#800)
  ci: enable benchmark on a PR basis (elastic#812)
  ci: use dockerLogs step (elastic#810)
  fix: env var invalid type (elastic#809)
  fix: workarount for elastic/beats#18858 (elastic#807)
  docs: add release notes for 5.2.0 (elastic#801)
  chore(release): publish
  fix(rum-core): consider user defined type of high precedence (elastic#798)
  fix(rum): use single instance of apm across all packages (elastic#796)
  ...
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
* Update set-up.asciidoc

I think it should be in quotes

* Update set-up.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants