ci: use dockerLogs step #810

v1v · 2020-06-02T13:05:59Z

What

It archives the docker container details for every stage that runs docker.

How to use it

Go to the artifact/docker-info folder
Look for the stage that you'd like to go deeper with
Open the file docker-containers.txt
Look for the container ID
<id>.log is the logs for the container with id
<id>-cmd.txt is the docker container run parameters
<id>-inspect.json is the output of the docker inspect command

Tests

(BO view)

Issues

Closes #806

apmmachine · 2020-06-02T13:10:45Z

💚 Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #810 updated]
Start Time: 2020-06-02T16:49:35.480+0000
Duration: 72 min 4 sec

Test stats 🧪

Test	Results
Failed	0
Passed	932
Skipped	10
Total	942

Steps errors

Expand to view the steps failures

Name: Bundlesize
- Description: #!/bin/bash set -o pipefail npm run bundlesize|tee bundlesize.txt
- Duration: 1 min 32 sec
- Start Time: 2020-06-02T16:54:45.657+0000
- log
Name: Start Elastic Stack 8.0.0-SNAPSHOT - @elastic/apm-rum-core - saucelabs
- Description:
- Duration: 4 min 58 sec
- Start Time: 2020-06-02T17:15:59.360+0000
- log
Name: Error signal
- Description:
- Duration: 0 min 0 sec
- Start Time: 2020-06-02T17:19:57.525+0000
- log

codecov-commenter · 2020-06-02T14:28:35Z

Codecov Report

Merging #810 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files          50       50           
  Lines        2291     2291           
  Branches      456      456           
=======================================
  Hits         2123     2123           
  Misses        165      165           
  Partials        3        3

Jenkinsfile

v1v · 2020-06-02T16:51:58Z

Jenkinsfile

-        sleep randomNumber(min: 5, max: 10)
-        if(env.MODE == 'saucelabs'){
-          withSaucelabsEnv(){
+      try {


This is required to be able to run a post-build step within this method. We could potentially add this section to the post-build always step. What do you prefer?

Alright, I'm afraid we cannot do the post-block though, the runAllScopes runs several scopes in a loop :(

mdelapenya

Maybe it's a good idea to have it in a post block, to always have it if needed

cachedout

I'm worried about this one. Won't docker inspect will dump all environment details? I'm concerned that we might end up leaking sensitive data. Even if that isn't the case now, we might accidentally forget that this is in place in the future.

v1v · 2020-06-03T10:53:12Z

I'm worried about this one. Won't docker inspect will dump all environment details? I'm concerned that we might end up leaking sensitive data. Even if that isn't the case now, we might accidentally forget that this is in place in the future.

What do you suggest?

cachedout · 2020-06-03T13:33:45Z

What do you suggest?

Sorry, I didn't see this comment earlier. I don't think we should ever do a docker inspect on a production CI job. I see that elastic/apm-pipeline-library#580 removes this capability so I think we are on the same page here. 👍

kuisathaverat · 2020-06-03T13:38:47Z

I'm worried about this one. Won't docker inspect will dump all environment details? I'm concerned that we might end up leaking sensitive data. Even if that isn't the case now, we might accidentally forget that this is in place in the future.

should not be secrets references in the docker-compose.yml, and the ones that can contain are related to the local containers and do not give access anywhere. In some cases, we need the inspect to see the status of the container when it died, we can remove the environment from the inspect output when we generate the file.

cachedout · 2020-06-03T13:45:27Z

we can remove the environment from the inspect output when we generate the file.

Parsing the output and removing the Envrionment value would satisfy my concerns. 👍

kuisathaverat · 2020-06-03T13:45:51Z

this makes the thing

docker inspect 60754aee9a26 |jq 'del(.[].Config.Env)'

* upstream/master: (23 commits) feat(rum-core): capture XHR/Fetch spans using resource timing (elastic#825) docs: update set-up.asciidoc (elastic#814) chore: remove compressed size gh workflow (elastic#828) feat: use page visibilityState for browser responsiveness check (elastic#813) ci(jenkins): report bundlesize as a GitHub comment (elastic#826) docs: release notes for 5.2.1 (elastic#824) chore(release): publish fix(rum-core): protect aganist buggy navigation timing data (elastic#819) fix(rum-core): protect aganist buggy navigation timing data (elastic#819) chore(rum-core): use startTime for LCP marks (elastic#815) fix(rum-core): capture tbt after all task entries are observed (elastic#803) feat(rum-react): use correct path when route is path array (elastic#800) ci: enable benchmark on a PR basis (elastic#812) ci: use dockerLogs step (elastic#810) fix: env var invalid type (elastic#809) fix: workarount for elastic/beats#18858 (elastic#807) docs: add release notes for 5.2.0 (elastic#801) chore(release): publish fix(rum-core): consider user defined type of high precedence (elastic#798) fix(rum): use single instance of apm across all packages (elastic#796) ...

ci: use dockerLogs step

122ccd7

v1v self-assigned this Jun 2, 2020

v1v added the automation label Jun 2, 2020

chore: testing purposes

8294ff5

v1v commented Jun 2, 2020

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

v1v and others added 2 commits June 2, 2020 17:02

ci: revert tests

ad3c3a3

ci: support matrix

0e21514

v1v marked this pull request as ready for review June 2, 2020 16:50

v1v requested review from vigneshshanmugam, hmdhk and a team June 2, 2020 16:50

v1v added the ci label Jun 2, 2020

v1v commented Jun 2, 2020

View reviewed changes

mdelapenya approved these changes Jun 2, 2020

View reviewed changes

cachedout reviewed Jun 3, 2020

View reviewed changes

v1v mentioned this pull request Jun 3, 2020

ci: exclude environments section in the docker inspect elastic/apm-pipeline-library#580

Merged

v1v merged commit 7ff7026 into elastic:master Jun 4, 2020

v1v deleted the feature/docker-logs branch June 4, 2020 07:13

David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021

ci: use dockerLogs step (elastic#810)

5c1ef54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: use dockerLogs step #810

ci: use dockerLogs step #810

v1v commented Jun 2, 2020 •

edited

Loading

apmmachine commented Jun 2, 2020 •

edited

Loading

Build stats

Test stats 🧪

codecov-commenter commented Jun 2, 2020

v1v Jun 2, 2020

v1v Jun 2, 2020

mdelapenya left a comment

cachedout left a comment

v1v commented Jun 3, 2020

cachedout commented Jun 3, 2020

kuisathaverat commented Jun 3, 2020

cachedout commented Jun 3, 2020

kuisathaverat commented Jun 3, 2020

ci: use dockerLogs step #810

ci: use dockerLogs step #810

Conversation

v1v commented Jun 2, 2020 • edited Loading

What

How to use it

Tests

Issues

apmmachine commented Jun 2, 2020 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

Steps errors

codecov-commenter commented Jun 2, 2020

Codecov Report

v1v Jun 2, 2020

Choose a reason for hiding this comment

v1v Jun 2, 2020

Choose a reason for hiding this comment

mdelapenya left a comment

Choose a reason for hiding this comment

cachedout left a comment

Choose a reason for hiding this comment

v1v commented Jun 3, 2020

cachedout commented Jun 3, 2020

kuisathaverat commented Jun 3, 2020

cachedout commented Jun 3, 2020

kuisathaverat commented Jun 3, 2020

v1v commented Jun 2, 2020 •

edited

Loading

apmmachine commented Jun 2, 2020 •

edited

Loading