Use eksctl commands (e.g. update core-dns) on non-eksctl created clusters #2174

kalbir · 2020-05-12T13:52:31Z

Why do you want this feature?
eksctl has some commands that make it easy to do things on clusters. So regardless of whether you created the cluster with eksctl or some other method, it could save yout time if you could use one of those commands on your cluster.

Examples that come to mind are:

eksctl utils update-coredns
eksctl create iamidentitymapping
eksctl create fargateprofile
eksctl upgrade nodegroup (eksctl upgrade nodegroup created from console #2698)

What feature/behavior/change do you want?

My initial thought is that you could pass some identifier for the cluster to eksctl (e.g. name and region) that will identify a unique cluster. eksctl could then look up that cluster and apply the correct command to it. So on the surface of things, eksctl would not change from a user perspective.

This would mean that eksctl get clusters could also show all the clusters that you have in your account, and indicate whether they were created by eksctl or not.

Then if you tried a command on a non-eksctl cluster that we could not complete, you'd get a message telling you why you couldn't do that (e.g. delete cluster).

The text was updated successfully, but these errors were encountered:

aclevername · 2020-10-30T14:23:40Z

Thanks for opening the issue @kalbir. You raise some excellent points around the current user experience when using eksctl against clusters that weren't created with eksctl. I've opened two recent PRs to try and improve the current experience #2779 and #2775. However these PRs only adress eksctl get clusters and eksctl create iamserviceaccount. As you point out there are many commands where eksctl doesn't work.

Your suggestion around changing it so that the UX seems reasonable to me. To recap the outcome of running a command against a non-eksctl created cluster would be either:

It works as expected
Where it doesn't work, it provides a good UX, e.g.

$ eksctl delete cluster --name cluster-created-in-console
[ℹ]  eksctl version 0.30.0
[ℹ]  Cannot delete cluster that was not created via eksctl (no associated CloudFormation stacks found)

It might be that over time we try to remove more occurrences of 2. and make eksctl smarter. For example at the moment it all of its interaction with creating clusters is through CloudFormation, meaning commands like eksctl delete cluster don't work as if you created the cluster manually it has no CloudFormation stack to delete. This could be overcome by making eksctl more aware of alternative methods of interacting with clusters.

aclevername · 2020-10-30T15:02:58Z

Edit: this list is out of date, see #2174 (comment).

I'm working my way through the commands to see what needs to change (will update this comment as I go along):

Works

eksctl get clusters Get clusters states if a cluster was eksctl created #2779
eksctl create iamserviceaccount Allow creation of iamserviceaccounts on clusters not created through eksctl #2775
eksctl create iamidentitymapping
eksctl delete iamserviceaccount
eksctl delete iamidentitymapping
eksctl enable profile
eksctl enable repo
eksctl get cluster
eksctl utils associate-iam-oidc-provider
eksctl utils describe-stacks (not applicable)
eksctl utils install-vpc-controllers
eksctl utils nodegroup-health
eksctl utils set-public-access-cidrs
eksctl utils update-cluster-endpoints
eksctl utils update-cluster-logging
eksctl utils write-kubeconfig
eksctl utils update-coredns
eksctl utils update-aws-node
eksctl utils update-kube-proxy

Needs adjusting

eksctl create fargateprofile (should be simple)
eksctl create nodegroup (difficult, how do we determine what values to use to create the nodegroup)
eksctl delete nodegroup (created a nodegroup manually through the console to test) (support for managed could be added, unmanaged seems unfeasible)
eksctl delete cluster
eksctl delete fargateprofile (could not create a fargateprofile to delete, needs further investigation) (should be simple)
eksctl drain nodegroup
eksctl get nodegroup
eksctl scale nodegroup
eksctl set labels (should be simple)
eksctl unset labels (should be simple)
eksctl update cluster
eksctl upgrade cluster (high priority)
eksctl upgrade nodegroup (used to work in the past, should be simple)

aclevername · 2020-11-10T10:09:29Z

Split into sub-issues:
#2808
#2809
#2810
#2811
#2812

aclevername · 2021-01-15T15:42:49Z

Update list as of 03/02/2021

Works

eksctl get clusters Get clusters states if a cluster was eksctl created #2779
eksctl create iamserviceaccount Allow creation of iamserviceaccounts on clusters not created through eksctl #2775
eksctl create iamidentitymapping
eksctl delete iamserviceaccount
eksctl delete iamidentitymapping
eksctl enable profile
eksctl enable repo
eksctl get cluster
eksctl utils associate-iam-oidc-provider
eksctl utils describe-stacks (not applicable)
eksctl utils install-vpc-controllers
eksctl utils nodegroup-health
eksctl utils set-public-access-cidrs
eksctl utils update-cluster-endpoints
eksctl utils update-cluster-logging
eksctl utils write-kubeconfig
eksctl utils update-coredns
eksctl utils update-aws-node
eksctl utils update-kube-proxy
eksctl delete nodegroup eksctl get/delete/drain support for non-eksctl created managed nodegroups #2809
eksctl drain nodegroup eksctl get/delete/drain support for non-eksctl created managed nodegroups #2809
eksctl get nodegroup eksctl get/delete/drain support for non-eksctl created managed nodegroups #2809
eksctl delete cluster Add support for deleting non-eksctl clusters #2969
eksctl upgrade cluster Support upgrading non eksctl clusters #2815
eksctl upgrade nodegroup Add support for upgrading non eksctl created nodegroups #2953
eksctl set labels Set/Unset/Get labels on unowned nodegroups #3168
eksctl unset labels Set/Unset/Get labels on unowned nodegroups #3168
eksctl get labels Set/Unset/Get labels on unowned nodegroups #3168
eksctl create fargateprofile
eksctl delete fargateprofile Add create fargateprofile support for non-eksctl-managed clusters #3080
eksctl scale nodegroup Add support for scaling non-eksctl created nodegroups #3132

Needs adjusting

eksctl create nodegroup eksctl create nodegroup support for non-eksctl clusters #3077

jmolero-cortical · 2021-01-18T18:05:45Z

Hi @aclevername thanks for you effort. At least in my case, the option 'eksctl upgrade nodegroup' is not working:

% eksctl version 0.36.0

`% eksctl upgrade nodegroup --name=NG-test --cluster=testcluster --kubernetes-version 1.18 --launch-template-version 2
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2d8c2b3]

goroutine 1 [running]:
github.com/weaveworks/eksctl/pkg/actions/nodegroup.(*Manager).upgradeAndWait(0xc0006379e0, 0x7ffeefbffb60, 0x13, 0x7ffeefbffba5, 0x4, 0x7ffeefbffbc4, 0x1, 0x0, 0x0, 0x0)
github.com/weaveworks/eksctl/pkg/actions/nodegroup/upgrade.go:60 +0x753
github.com/weaveworks/eksctl/pkg/actions/nodegroup.(*Manager).Upgrade(0xc0006379e0, 0x7ffeefbffb60, 0x13, 0x7ffeefbffba5, 0x4, 0x7ffeefbffbc4, 0x1, 0x0, 0xc0001ca8b0, 0xc000240d90)
github.com/weaveworks/eksctl/pkg/actions/nodegroup/upgrade.go:38 +0x3e6
github.com/weaveworks/eksctl/pkg/ctl/upgrade.upgradeNodeGroup(0xc0006274a0, 0x7ffeefbffb60, 0x13, 0x7ffeefbffba5, 0x4, 0x7ffeefbffbc4, 0x1, 0x0, 0x1179565, 0xc0000d8400)
github.com/weaveworks/eksctl/pkg/ctl/upgrade/nodegroup.go:86 +0x311
github.com/weaveworks/eksctl/pkg/ctl/upgrade.upgradeNodeGroupCmd.func1(0xc0000da000, 0xc00009cc60, 0x0, 0x6, 0x0, 0x0)
github.com/weaveworks/eksctl/pkg/ctl/upgrade/nodegroup.go:27 +0xef
github.com/spf13/cobra.(*Command).execute(0xc0000da000, 0xc00009cc00, 0x6, 0x6, 0xc0000da000, 0xc00009cc00)
github.com/spf13/[email protected]/command.go:850 +0x47c
github.com/spf13/cobra.(*Command).ExecuteC(0xc000844840, 0xc00064db10, 0x1, 0xc0008e9f70)
github.com/spf13/[email protected]/command.go:958 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
github.com/spf13/[email protected]/command.go:895
main.main()
github.com/weaveworks/eksctl/cmd/eksctl/main.go:76 +0x3ec`

aclevername · 2021-01-18T18:33:55Z

Hi @aclevername thanks for you effort. At least in my case, the option 'eksctl upgrade nodegroup' is not working:

`% eksctl version

0.36.0`

`% eksctl upgrade nodegroup --name=NG-test --cluster=testcluster --kubernetes-version 1.18 --launch-template-version 2

panic: runtime error: invalid memory address or nil pointer dereference

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2d8c2b3]

goroutine 1 [running]:

github.com/weaveworks/eksctl/pkg/actions/nodegroup.(*Manager).upgradeAndWait(0xc0006379e0, 0x7ffeefbffb60, 0x13, 0x7ffeefbffba5, 0x4, 0x7ffeefbffbc4, 0x1, 0x0, 0x0, 0x0)

github.com/weaveworks/eksctl/pkg/actions/nodegroup/upgrade.go:60 +0x753

github.com/weaveworks/eksctl/pkg/actions/nodegroup.(*Manager).Upgrade(0xc0006379e0, 0x7ffeefbffb60, 0x13, 0x7ffeefbffba5, 0x4, 0x7ffeefbffbc4, 0x1, 0x0, 0xc0001ca8b0, 0xc000240d90)

github.com/weaveworks/eksctl/pkg/actions/nodegroup/upgrade.go:38 +0x3e6

github.com/weaveworks/eksctl/pkg/ctl/upgrade.upgradeNodeGroup(0xc0006274a0, 0x7ffeefbffb60, 0x13, 0x7ffeefbffba5, 0x4, 0x7ffeefbffbc4, 0x1, 0x0, 0x1179565, 0xc0000d8400)

github.com/weaveworks/eksctl/pkg/ctl/upgrade/nodegroup.go:86 +0x311

github.com/weaveworks/eksctl/pkg/ctl/upgrade.upgradeNodeGroupCmd.func1(0xc0000da000, 0xc00009cc60, 0x0, 0x6, 0x0, 0x0)

github.com/weaveworks/eksctl/pkg/ctl/upgrade/nodegroup.go:27 +0xef

github.com/spf13/cobra.(*Command).execute(0xc0000da000, 0xc00009cc00, 0x6, 0x6, 0xc0000da000, 0xc00009cc00)

github.com/spf13/[email protected]/command.go:850 +0x47c

github.com/spf13/cobra.(*Command).ExecuteC(0xc000844840, 0xc00064db10, 0x1, 0xc0008e9f70)

github.com/spf13/[email protected]/command.go:958 +0x375

github.com/spf13/cobra.(*Command).Execute(...)

github.com/spf13/[email protected]/command.go:895

main.main()

github.com/weaveworks/eksctl/cmd/eksctl/main.go:76 +0x3ec`

Thanks for reporting the issue! Can you create a new bug report issue with the config file/cluster details? Thanks

Callisto13 · 2021-03-01T16:04:31Z

From 0.40.0 you should be able to use any eksctl command on any EKS cluster. Docs will be updated by the end of the week.

kalbir · 2021-03-01T17:25:39Z

Nice work! Very pleased this has been shipped ☺️

yysu · 2021-03-25T09:18:58Z

Can't wait to see this !

aclevername · 2021-03-25T10:27:47Z

From 0.40.0 you should be able to use any eksctl command on any EKS cluster. Docs will be updated by the end of the week.

Docs will be out with this weeks release, I'm going to close this issue now as the work is done! 😄

kalbir added the kind/feature New feature or request label May 12, 2020

cPu1 mentioned this issue Jun 19, 2020

No eksctl-managed CloudFormation stacks found error with AWS QuickStart template #1930

Closed

martina-if added the priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases label Sep 9, 2020

michaelbeaumont self-assigned this Oct 9, 2020

michaelbeaumont assigned aclevername and unassigned michaelbeaumont Oct 27, 2020

aclevername mentioned this issue Oct 27, 2020

Allow creation of iamserviceaccounts on clusters not created through eksctl #2775

Merged

5 tasks

michaelbeaumont mentioned this issue Oct 29, 2020

eksctl upgrade nodegroup created from console #2698

Closed

Callisto13 mentioned this issue Dec 15, 2020

Reduce the number of external API calls #2946

Closed

aclevername removed their assignment Jan 18, 2021

jmolero-cortical mentioned this issue Jan 18, 2021

panic: runtime error: invalid memory address with eksctl upgrade nodegroup #3102

Closed

jlbutler mentioned this issue Feb 4, 2021

updates related to eksctl operations on non-eksctl clusters awsdocs/amazon-eks-user-guide#303

Merged

aclevername mentioned this issue Feb 10, 2021

Add docs for non-eksctl created clusters support #3249

Closed

aclevername closed this as completed Mar 25, 2021

aclevername mentioned this issue Oct 12, 2021

Import an existing EKS cluster #807

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use eksctl commands (e.g. update core-dns) on non-eksctl created clusters #2174

Use eksctl commands (e.g. update core-dns) on non-eksctl created clusters #2174

kalbir commented May 12, 2020 •

edited by michaelbeaumont

Loading

aclevername commented Oct 30, 2020 •

edited

Loading

aclevername commented Oct 30, 2020 •

edited by Callisto13

Loading

aclevername commented Nov 10, 2020

aclevername commented Jan 15, 2021 •

edited by Callisto13

Loading

jmolero-cortical commented Jan 18, 2021

aclevername commented Jan 18, 2021

Callisto13 commented Mar 1, 2021 •

edited

Loading

kalbir commented Mar 1, 2021

yysu commented Mar 25, 2021

aclevername commented Mar 25, 2021

Use eksctl commands (e.g. update core-dns) on non-eksctl created clusters #2174

Use eksctl commands (e.g. update core-dns) on non-eksctl created clusters #2174

Comments

kalbir commented May 12, 2020 • edited by michaelbeaumont Loading

aclevername commented Oct 30, 2020 • edited Loading

aclevername commented Oct 30, 2020 • edited by Callisto13 Loading

Works

Needs adjusting

aclevername commented Nov 10, 2020

aclevername commented Jan 15, 2021 • edited by Callisto13 Loading

Works

Needs adjusting

jmolero-cortical commented Jan 18, 2021

aclevername commented Jan 18, 2021

Callisto13 commented Mar 1, 2021 • edited Loading

kalbir commented Mar 1, 2021

yysu commented Mar 25, 2021

aclevername commented Mar 25, 2021

kalbir commented May 12, 2020 •

edited by michaelbeaumont

Loading

aclevername commented Oct 30, 2020 •

edited

Loading

aclevername commented Oct 30, 2020 •

edited by Callisto13

Loading

aclevername commented Jan 15, 2021 •

edited by Callisto13

Loading

Callisto13 commented Mar 1, 2021 •

edited

Loading