-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get clusters states if a cluster was eksctl created #2779
Conversation
@michaelbeaumont @cPu1 any idea what this test is about? Test: 2785d9b It started failing when I moved the print logic into the clt/get package, but I don't understand the test enough to understand what it does or how to fix it, so I removed it. |
Looking into it further it appears to be testing when the |
Description
Some eksctl commands are supported against clusters that are created through eksctl, and some are not. Currenty using the CLI you cannot discover which clusters were created through eksctl. This PR adds a
EKSCTL CREATED
column to theeksctl get clusters
output to indicate whether or not the cluster was created by eksctl.As part of #2775 clusters that weren't created by eksctl can now have stacks associated to them, such as a stack for creating the iamserviceaccount. To check that a cluster is eksctl created it checks that 1. it has a stack with the
eksctl
tags and 2. It has theClusterStackName
as one of the outputs. Im open for changing 2. to check for something else that is unique to clusters, this was just the easiest to pick.Others
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
), target version (e.g.version/0.12.0
) and kind (e.g.kind/improvement
)