Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get clusters states if a cluster was eksctl created #2779

Merged
merged 19 commits into from
Nov 3, 2020

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Oct 28, 2020

Description

Some eksctl commands are supported against clusters that are created through eksctl, and some are not. Currenty using the CLI you cannot discover which clusters were created through eksctl. This PR adds a EKSCTL CREATED column to the eksctl get clusters output to indicate whether or not the cluster was created by eksctl.

As part of #2775 clusters that weren't created by eksctl can now have stacks associated to them, such as a stack for creating the iamserviceaccount. To check that a cluster is eksctl created it checks that 1. it has a stack with the eksctl tags and 2. It has the ClusterStackName as one of the outputs. Im open for changing 2. to check for something else that is unique to clusters, this was just the easiest to pick.

Others

  • Minor refactoring to seperate our get cluster vs get clusters
  • backfill of tests

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@aclevername
Copy link
Contributor Author

@michaelbeaumont @cPu1 any idea what this test is about?

Test: 2785d9b
Associated test data file: 2e6bddf

It started failing when I moved the print logic into the clt/get package, but I don't understand the test enough to understand what it does or how to fix it, so I removed it.

@aclevername
Copy link
Contributor Author

aclevername commented Nov 2, 2020

@michaelbeaumont @cPu1 any idea what this test is about?

Test: 2785d9b
Associated test data file: 2e6bddf

It started failing when I moved the print logic into the clt/get package, but I don't understand the test enough to understand what it does or how to fix it, so I removed it.

Looking into it further it appears to be testing when the --output json flag is provided to the eksctl get cluster. I don't think its worth re-adding this test as all it tests is the printer package.

@michaelbeaumont michaelbeaumont merged commit 7db9b8b into master Nov 3, 2020
@michaelbeaumont michaelbeaumont deleted the get-clusters-lists-non-eksctl branch November 3, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants