Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eksctl upgrade nodegroup created from console #2698

Closed
cdenneen opened this issue Oct 1, 2020 · 2 comments
Closed

eksctl upgrade nodegroup created from console #2698

cdenneen opened this issue Oct 1, 2020 · 2 comments
Assignees
@michaelbeaumont
Labels
kind/bug priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@cdenneen
Copy link

cdenneen commented Oct 1, 2020

What happened?
In version 0.28.1 you cannot upgrade a nodegroup that wasn't created via eksctl because it does not have a stack to perform the update on.

What you expected to happen?
In version 0.24.0 you could upgrade a nodegroup via eksctl even if it wasn't created via eksctl (no stack)
I expect if a stack can't be found it will use the API call to upgrade the nodegroup as it did in 0.24.0

Running 0.28.1

❯ eksctl upgrade nodegroup --name testing-nodegroup --cluster apss-use1-c1
Error: error fetching nodegroup template: describing CloudFormation stack "eksctl-apss-use1-c1-nodegroup-testing-nodegroup": ValidationError: Stack with id eksctl-apss-use1-c1-nodegroup-testing-nodegroup does not exist
	status code: 400, request id:

Running 0.24.0

❯ brew unlink eksctl
Unlinking /usr/local/Cellar/eksctl/0.28.1... 3 symlinks removed
❯ brew link [email protected]
Linking /usr/local/Cellar/[email protected]/0.24.0... 3 symlinks created
❯ eksctl version
0.24.0
❯ eksctl upgrade nodegroup --name testing-nodegroup --cluster apss-use1-c1 --kubernetes-version 1.16
[ℹ]  upgrading nodegroup to release version 1.16.13-20200921
Error: timed out waiting for nodegroup update to complete: context deadline exceeded

The timeout I think needs to be fixed but the upgrade is successful
@michaelbeaumont michaelbeaumont self-assigned this Oct 9, 2020
@michaelbeaumont michaelbeaumont added priority/important-soon Ideally to be resolved in time for the next release priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases and removed priority/important-soon Ideally to be resolved in time for the next release labels Oct 29, 2020
@michaelbeaumont michaelbeaumont mentioned this issue Oct 29, 2020
Closed
@michaelbeaumont
Copy link
Contributor

Thanks @cdenneen, I'm going to track this in #2174

@michaelbeaumont
Copy link
Contributor

Duplicate of #2174

@michaelbeaumont michaelbeaumont marked this as a duplicate of #2174 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbeaumont michaelbeaumont

Labels
kind/bug priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdenneen @michaelbeaumont