Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement for cgi module #19

Closed
wants to merge 9 commits into from
Closed

Conversation

iainrussell
Copy link
Member

This should fix the issues seen with #15.

@FussyDuck
Copy link

FussyDuck commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 13.90%. Comparing base (65ad776) to head (e366966).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
multiurl/http.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   13.24%   13.90%   +0.65%     
==========================================
  Files          14       14              
  Lines        1034     1043       +9     
==========================================
+ Hits          137      145       +8     
- Misses        897      898       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iainrussell
Copy link
Member Author

Resolved in a slightly nicer way by #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants