Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cgi #15

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Remove cgi #15

merged 3 commits into from
Oct 14, 2024

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented Oct 9, 2024

Fixes #14

@FussyDuck
Copy link

FussyDuck commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@EddyCMWF
Copy link
Collaborator

Hi @ocefpaf ,

Many thanks for your contribution, is there any chance you can update the PR with QA fix applied? Executing the following in the repo should be enough:

pip install black isort flake8
black .
isort .
flake8 .

Many thanks,
Eddy

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Oct 10, 2024

is there any chance you can update the PR with QA fix applied?

Sure. Done in the last commit.

@EddyCMWF
Copy link
Collaborator

Hi again, sory for the delay on following up on this. I had to update the GH actions on the main branch. Could you please merge from main so that the python3.7 test is removed

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Oct 14, 2024

Hi again, sory for the delay on following up on this. I had to update the GH actions on the main branch. Could you please merge from main so that the python3.7 test is removed

Done!

@EddyCMWF EddyCMWF merged commit 77b3878 into ecmwf:main Oct 14, 2024
18 checks passed
@EddyCMWF
Copy link
Collaborator

Mnay thanks for your contributions @ocefpaf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cgi deprecated in python 3.13
5 participants