Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement for cgi module #19

Closed
wants to merge 9 commits into from
Closed

Fix replacement for cgi module #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c58a7f7
Fix replacement for cgi module
iainrussell Oct 31, 2024
bbe388a
test for content-disposition
EddyCMWF Nov 6, 2024
1fd5ce7
test for content-disposition
EddyCMWF Nov 6, 2024
c939082
remove unused module
EddyCMWF Nov 6, 2024
76aca25
remove unused code
EddyCMWF Nov 6, 2024
22706aa
Add test for fix for replacement for cgi module
iainrussell Nov 6, 2024
25b7b06
Merge branch 'fix/fix-cgi-replacement' into test-for-cgi
iainrussell Nov 6, 2024
a57b5f7
Merge pull request #20 from ecmwf/test-for-cgi
iainrussell Nov 6, 2024
e366966
Add test for fix for replacement for cgi module
iainrussell Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion multiurl/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ def parse_separated_header(value: str):

m = Message()
m["content-type"] = value
return dict(m.get_params())
e1, e2 = m.get_params()
return e1[0], dict([e2])


class HTTPDownloaderBase(DownloaderBase):
Expand Down
13 changes: 13 additions & 0 deletions tests/test_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import pytest

from multiurl import Downloader, download
from multiurl.http import FullHTTPDownloader


def test_http():
Expand Down Expand Up @@ -77,6 +78,18 @@ def test_order():
assert f.read()[:4] == b"BUFR"


def test_content_disposition_handling():
class TestDownloader(FullHTTPDownloader):
def headers(self):
headers = super().headers()
headers["content-disposition"] = 'attachment; filename="temp.bufr"'
return headers

TestDownloader(
url="http://get.ecmwf.int/test-data/metview/gallery/temp.bufr",
).download(target="out")


@pytest.mark.skip(reason="ftpserver not defined")
def test_ftp_download(tmp_path, ftpserver):
local_test_file = os.path.join(tmp_path, "testfile.txt")
Expand Down
Loading