Fixed Peak/Scan List not updating when adding scan identifiers #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is problematic as it's not possible to select more than one peak in the peak list any longer. Additionally, the selection disappears immediately in the peak/scan list due to updating the chromatogram selection. The problem arises from this change:
Please test it on your side. Try to select one or more peaks in the peak/scan list. |
Mailaender
force-pushed
the
dirty-scans
branch
from
a3f4c88 to
af5e3fb
Compare
|
That change is actually not at all required for this to work. I removed it. |
|
In the current change, two clicks are required to select a peak/scan in the list if the focus was lost. Is that intended? |
|
No, that is a recent regression. I seem to have introduced this in #913. Added a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and scan identifiers not dirtying the chromatogram which makes this a followup to #875.
Closes #918