Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Peak/Scan list not updating when hidden in the background #913

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

Mailaender
Copy link
Contributor

Closes #912

@eselmeister
Copy link
Contributor

Looks good. I would additionally recommend to check with instanceof if the object is a chromatogram selection:

@Override
public boolean setFocus() {

	DataUpdateSupport dataUpdateSupport = Activator.getDefault().getDataUpdateSupport();
	List<Object> objects = dataUpdateSupport.getUpdates(IChemClipseEvents.TOPIC_CHROMATOGRAM_XXD_UPDATE_SELECTION);
	if(!objects.isEmpty() && objects.get(0) instanceof IChromatogramSelection) {
		chromatogramSelection = (IChromatogramSelection)objects.get(0);
	}
	updateChromatogramSelection();
	return true;
}

@Mailaender Mailaender force-pushed the peak-scan-list-update branch from 7ae9854 to 42e866e Compare February 22, 2022 13:27
@Mailaender
Copy link
Contributor Author

Added the missing check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peak/Scan List does not update on opening a new chromatogram
2 participants