Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak/Scan List not updated automatically from Scan Identifiers, Peak Detector #918

Closed
lorenzgerber opened this issue Feb 22, 2022 · 3 comments · Fixed by #920
Closed

Peak/Scan List not updated automatically from Scan Identifiers, Peak Detector #918

lorenzgerber opened this issue Feb 22, 2022 · 3 comments · Fixed by #920

Comments

@lorenzgerber
Copy link
Contributor

Currently, when a Scan Identifier or Peak Detector is run, while the Peak/Scan List is already open (independent whether it's currently visible or not) the Peak/Scan List is not updated. A manual press to the 'Reset Peak/Scan List' is required to visualise the Peaks/Scans in the List.

Requested behaviour would be that running an above operations will update the Peak/Scan List, ideally independent from whether it's currently visible or not. Having a GUI application, it feels counter intuitive that you have to press a reset button to obtain data. If there is no way to solve it, I suggest that 'update data' button would be a better name.

Tested on OSX, both on MSD and WSD chromatogram

Note that this is different from #913 which now works (opening/closing a chromatogram will fire an update on the Peak/Scan List).

@Mailaender
Copy link
Contributor

Right-click chromatogram peak detection works fine for me. However, scan identifiers never update no matter from where it is set.

@lorenzgerber
Copy link
Contributor Author

ok, works for MSD, but still not for WSD

@Mailaender
Copy link
Contributor

ok, works for MSD, but still not for WSD

It also works for WSD, when using 1st derivative peak detector.

Add dirty handling to yours b6b8703#diff-ac58f193737f030e7e04e24ddc7e5444e117ebafb0ce1b9159074bfc21e80d61 and it should solve the peak/scan list not updating.

For peak detection, this may want to be handled at a higher level in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants