Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable workflow Helm test on PRs #25

Merged

Conversation

fty4
Copy link
Member

@fty4 fty4 commented Jun 16, 2023

I'd love if the Helm test workflow is running on PRs.

This would help to verify if a PR breaks the Helm chart.
Currently it is only triggered via manual workflow_dispatch.
Other projects in eclipse-tractusx test it the same way.


Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

@fty4 fty4 requested review from SebastianBezold and carslen June 16, 2023 05:55
@fty4
Copy link
Member Author

fty4 commented Jun 16, 2023

current issues:

https://github.com/eclipse-tractusx/e2e-testing/blob/6c332561980ba508d2a36c9c84b0958f353c2d99/charts/umbrella/charts/certs/templates/job-daps.yaml#L54-L63

Fixes should happen in other PR (IMHO)

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@almadigabor
Copy link
Contributor

Probably need to include the fixed chart dependencies in this PR for the helm test to pass.

@fty4
Copy link
Member Author

fty4 commented Jun 19, 2023

Probably need to include the fixed chart dependencies in this PR for the helm test to pass.

You are right - the mentioned issues above should be the problems. But I think these changes should be in another PR.

@almadigabor
Copy link
Contributor

almadigabor commented Jun 20, 2023

Probably need to include the fixed chart dependencies in this PR for the helm test to pass.

You are right - the mentioned issues above should be the problems. But I think these changes should be in another PR.

That is true but until we have the fixes in this branch, the test workflow will fail and PR can't be merged.

@fty4
Copy link
Member Author

fty4 commented Jun 21, 2023

I just tested it with the changes from #22.
The test was successfully.

Therefore I will wait until this mentioned PR is merged.

Helm test
 helm test e2e                                                                       
NAME: e2e
LAST DEPLOYED: Wed Jun 21 09:57:44 2023
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE:     e2e-server-test
Last Started:   Wed Jun 21 10:01:56 2023
Last Completed: Wed Jun 21 10:02:00 2023
Phase:          Succeeded
TEST SUITE:     e2e-edcconsumertest-controlplane-readiness
Last Started:   Wed Jun 21 10:01:37 2023
Last Completed: Wed Jun 21 10:01:42 2023
Phase:          Succeeded
TEST SUITE:     e2e-edcconsumertest-dataplane-readiness
Last Started:   Wed Jun 21 10:01:42 2023
Last Completed: Wed Jun 21 10:01:47 2023
Phase:          Succeeded
TEST SUITE:     e2e-edcprovidertest-controlplane-readiness
Last Started:   Wed Jun 21 10:01:47 2023
Last Completed: Wed Jun 21 10:01:52 2023
Phase:          Succeeded
TEST SUITE:     e2e-edcprovidertest-dataplane-readiness
Last Started:   Wed Jun 21 10:01:52 2023
Last Completed: Wed Jun 21 10:01:56 2023
Phase:          Succeeded

@fty4
Copy link
Member Author

fty4 commented Jun 26, 2023

As assumed - after merging #22 the test will succeed.

@almadigabor
Copy link
Contributor

As assumed - after merging #22 the test will succeed.

Great!:) Can I merge this commit now?

@fty4
Copy link
Member Author

fty4 commented Jun 28, 2023

yes would be great if this will be merged

@almadigabor almadigabor merged commit 719eb1a into eclipse-tractusx:main Jul 4, 2023
@fty4 fty4 deleted the chore/wf-helmtest-pr branch July 4, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants