-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): enable workflow Helm test on PRs #25
chore(ci): enable workflow Helm test on PRs #25
Conversation
current issues:
Fixes should happen in other PR (IMHO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Probably need to include the fixed chart dependencies in this PR for the helm test to pass. |
You are right - the mentioned issues above should be the problems. But I think these changes should be in another PR. |
That is true but until we have the fixes in this branch, the test workflow will fail and PR can't be merged. |
I just tested it with the changes from #22. Therefore I will wait until this mentioned PR is merged. Helm test helm test e2e
NAME: e2e
LAST DEPLOYED: Wed Jun 21 09:57:44 2023
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: e2e-server-test
Last Started: Wed Jun 21 10:01:56 2023
Last Completed: Wed Jun 21 10:02:00 2023
Phase: Succeeded
TEST SUITE: e2e-edcconsumertest-controlplane-readiness
Last Started: Wed Jun 21 10:01:37 2023
Last Completed: Wed Jun 21 10:01:42 2023
Phase: Succeeded
TEST SUITE: e2e-edcconsumertest-dataplane-readiness
Last Started: Wed Jun 21 10:01:42 2023
Last Completed: Wed Jun 21 10:01:47 2023
Phase: Succeeded
TEST SUITE: e2e-edcprovidertest-controlplane-readiness
Last Started: Wed Jun 21 10:01:47 2023
Last Completed: Wed Jun 21 10:01:52 2023
Phase: Succeeded
TEST SUITE: e2e-edcprovidertest-dataplane-readiness
Last Started: Wed Jun 21 10:01:52 2023
Last Completed: Wed Jun 21 10:01:56 2023
Phase: Succeeded |
As assumed - after merging #22 the test will succeed. |
Great!:) Can I merge this commit now? |
yes would be great if this will be merged |
I'd love if the Helm test workflow is running on PRs.
This would help to verify if a PR breaks the Helm chart.
Currently it is only triggered via manual
workflow_dispatch
.Other projects in eclipse-tractusx test it the same way.
Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)