-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): rework chart to use latest tractusx-connector chart #22
feat(helm): rework chart to use latest tractusx-connector chart #22
Conversation
bitnami and hashicorp are not longer required - the dependencies are loaded via tx-c chart directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should rename the chart to someting meaningfull in the future
see issue #23 |
edc This version does not use daps-server anymore but Managed Identity Walled (MIW) / SSI. |
I just tried to use Helm chart But the dataplane will not start.
full logs
|
Hi @fty4, I think removing our custom sub Charts for products, that already provide their own Chart is great! Using the existing ones that are maintained by the product teams as dependency should be our default. Regarding the EDC version:
Since there is not really any activity (that I know of) in regards to test automation, I guess the better option to go for is 2). If at least the SSI enabled EDC is starting up and is integrated as a dependency, that would be fine in my opinion. Regarding external transitive dependencies: FYI @Siegfriedk |
temporary using fixed image + tag Because there is no tractusx-connector release including PRs 473,474,475 for 0.4.x we use the legacy Helm chart from release 0.5.0-rc1
I've just updated the PR to use the The PR is now not longer a draft and can be reviewed and merged. @SebastianBezold I think we should first merge this PR then the daps still will be in place. |
Hi @fty4, agree. Could you please create issues to track the "new Chart version but 'old' EDC version"? |
issue created: #27 |
TL;DR
The current e2e-testing is using separate daps, psql and vault dependencies - these are now provided inside the
tractusx-connector
chart.With this PR the dependencies of the tx-c chart will be used instead of creating own dependencies.
Description
Currently the Helm chart is using its own
daps-server
,postgresql
andvault
dependency.That was the case because the edc chart did not yet provide those.
But that changed since v0.4.1 was released.
Therefore instead of providing separate dependencies to the
tractusx-connector
chart its dependencies can be used for the e2e-testing umbrella chart.Due the fact that only one
daps-server
andvault
is required both are deactivated on the edcprovider dependency.Each edc will receive its own psql.
Currently there are some changes which are required to be able to deploy this new structure.
daps, postgresql and vault need to allow templating in their application fullname.
This also will allow all components share the same prefix (
{{ .Release.Name }}-
).Also the configuration in the values file will be simplified.
The PRs are linked below.
Test PR
Currently there is a way to test the new umbrella chart with a test-release from mercedes-benz/eclipse-tractusx_tractusx-edc-merge:
Test instructions
Chart.yaml
Update your
Chart.yaml
of the umbrella chart as follows:Note: Version
0.4.1-PR473-474-475
represents v0.4.1 with all of the required PRs merged.values-patch-image.yaml
Because the version is referencing its own version also the values file requires following additional configuration (e.g. additional value.yaml-file):
Installation
Dependencies
As mentioned following changes in the tractusx-connector Helm chart are required to be released:
Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)