Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

fix(helm): use openid-configuration path for Helm test #38

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

fty4
Copy link
Member

@fty4 fty4 commented Jun 2, 2023

When testing against the root path the server will return a 404 status code which results in an unsuccessful test:

$ helm test lab 
NAME: lab
LAST DEPLOYED: Fri Jun  2 09:13:17 2023
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE:     lab-dapsserver-test-connection
Last Started:   Fri Jun  2 09:16:46 2023
Last Completed: Fri Jun  2 09:16:51 2023
Phase:          Failed
Error: 1 error occurred:
        * pod lab-dapsserver-test-connection failed

When changing the endpoint to /.well-known/openid-configuration a HTTP/1.1 200 OK will be returned:

$ helm test lab                                  
NAME: lab
LAST DEPLOYED: Fri Jun  2 09:43:00 2023
NAMESPACE: default
STATUS: deployed
REVISION: 3
TEST SUITE:     lab-dapsserver-test-connection
Last Started:   Fri Jun  2 09:43:03 2023
Last Completed: Fri Jun  2 09:43:08 2023
Phase:          Succeeded
TEST SUITE:     lab-server-test
Last Started:   Fri Jun  2 09:43:08 2023
Last Completed: Fri Jun  2 09:43:11 2023
Phase:          Succeeded

Marco Lecheler [email protected] Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

fty4 added 3 commits June 2, 2023 09:55
When testing against the root path the server will return a 404 status code which results in an unsuccessful test.
@fty4 fty4 requested a review from adkumar1 June 2, 2023 11:30
Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carslen carslen merged commit e760176 into eclipse-tractusx:main Jun 7, 2023
@fty4 fty4 deleted the fix/helm-test branch June 7, 2023 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants