Add CRIU testing

[tajila]

Add tests for CRIUSupport

CRIU is supported on JDK11+ and will likely be supported on JDK8 as well. However, CRIU enabled JDKs need to be built with a special configure option --enable-criu-support and they can only be run on machines with CRIU installed. CRIU is only supported on linux.

We need a way to add a tag to these tests that reflect their special properties while still enabling them to run on all JDK levels.

• label the CRIU machine with the correct label (label name TBD - sw.tool.criu? )
• add new linux platforms (i.e., x86-64_linux_criu) in openjdk_tests (Related:
• Add criu build targets Add criu build targets #14241)
• add new system properties to determine if CRIU is enabled in the JDK
• update TKG to auto-detect the spec with CRIU
• update modes (Ottawa.csv)
• add feature.criu in platformRequirements

Update: if we have CRIU installed on all linux, I think we do not need the specific label on the machines. And maybe we can also avoid update modes (Ottawa.csv).

[tajila]

@llxia Do you have any advice on how to proceed with this.

Ideally we would add tests to Java8AndUp under sanity.functional.

Perhaps we can make criu a </platformRequirements>? or maybe a test <types>

[llxia]

Assuming that we have a new SPEC for this and we can detect it using system property, then we can use </platformRequirements>. All CRUI machines should add the proper label, and the test pipeline also needs to be updated to look for the correct label.

Do we plan to run CRIU specific tests and the rest of the tests together? If not, we may need to use TESTLIST for now.

Also, in discussion with @renfeiw of supporting feature-specific testing in TKG moving forward.

[tajila]

Do we plan to run CRIU specific tests and the rest of the tests together?

Yes, ideally we would do both

[llxia]

Do we have a CRIU enabled JDK and machine for us to try?

[tajila]

@llxia No we dont have a machine yet. But if you can install libcriu locally. Ive test it on Ubuntu 18.04

[vijaysun-omr]

This is part of issue 16384

[tajila]

@llxia For platform requirements I noticed some have bits.64

<platformRequirements>os.linux,arch.x86,bits.64</platformRequirements>

Could we do something similar for criu?

[llxia]

I think so. If you do not mind, I would like to discuss this more in detail. Maybe sometime after Christmas or in Jan.

[tajila]

I think so. If you do not mind, I would like to discuss this more in detail. Maybe sometime after Christmas or in Jan.

Sure, that sounds good

[llxia]

Thanks @tajila and @renfeiw for the discussion. Here are the ToDos:

• label the CRIU machine with the correct label (label name TBD - sw.tool.criu? see internal issue )
• add new linux platforms (i.e., x86-64_linux_criu) in openjdk_tests (Related: Add criu build targets #14241)
• add new system properties to determine if CRIU is enabled in the JDK
• update TKG to auto-detect the spec with CRIU Auto detect TEST_FLAG adoptium/TKG#269
• update modes (Ottawa.csv)
• add feature.criu in platformRequirements feature tag is added Add feature into TKG adoptium/TKG#267

Update: if we have CRIU installed on all linux, I think we do not need the specific label on the machines. And maybe we can also avoid update modes (Ottawa.csv).

[tajila]

@llxia Is it possible to create a test that requires usage of two machines?

Here is a scenario that I'm thinking about. Create a checkpoint on HostA, restore it on Host B.

The requirement would be that the platform is the same, so linux_x86 to linux_x86, however the OS versions may differ, ie. ubuntu to rhel

[llxia]

Is it possible to create a test that requires usage of two machines?

ah, we were just talking about this - see issue adoptium/aqa-tests#2841
This issue title is about server and client, but the solution will be generic. How the machine is used will depend on the test itself. We can discuss if you have any specific requirements.

FYI @smlambert