-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPb: Add role to install CRIU on Linux x86-64 #2519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of extra prerequisites. Is this needed during the build when configured with --enable-criu-support
, the normal testing cycles, or only when attempting to use the CRIU functionality? I'm guessing there will be some new tests in the suites (functional?) to cover this?
re: new tests, CRIU is a major new feature, this is an example and first of many new tests to be added eclipse-openj9/openj9#14531. |
2f6c1d0
to
ecd1300
Compare
@vsebe Can you confirm the answers to these questions from earlier please:
Also a couple of extra points:
|
Yes to all. It is required for building and testing OpenJ9 with criu support for JDK11+. Criu support for build is enabled with
We still have Ubuntu16 machines on openj9-jenkins. This PR addresses 16, 18 and 20.
Yes, it is. We have a different top level playbook for the IBM machines. @sxa fyi |
af0d2c6
to
b3ddb6f
Compare
Add role to install CRIU on CentOS/RHEL 7 and Ubuntu. Required by OpenJ9. Related: eclipse-openj9/openj9#14016 Signed-off-by: Violeta Sebe <[email protected]>
I updated the task for Ubuntu 22. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is. We have a different top level playbook for the IBM machines.
On that basis I'm ok with it. Thanks for all the clarifications on the above points too - good to know :-) As long as we continue to build without --enable-criu-support
it shouldn't affect us then.
Add role to install CRIU on CentOS/RHEL 7 and Ubuntu.
Required by OpenJ9.
Related: eclipse-openj9/openj9#14016
Signed-off-by: Violeta Sebe [email protected]
Checklist