Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPb: Add role to install CRIU on Linux x86-64 #2519

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

vsebe
Copy link
Contributor

@vsebe vsebe commented Mar 31, 2022

Add role to install CRIU on CentOS/RHEL 7 and Ubuntu.
Required by OpenJ9.
Related: eclipse-openj9/openj9#14016

Signed-off-by: Violeta Sebe [email protected]

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@karianna karianna requested a review from sxa April 1, 2022 16:03
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of extra prerequisites. Is this needed during the build when configured with --enable-criu-support, the normal testing cycles, or only when attempting to use the CRIU functionality? I'm guessing there will be some new tests in the suites (functional?) to cover this?

@smlambert
Copy link
Contributor

re: new tests, CRIU is a major new feature, this is an example and first of many new tests to be added eclipse-openj9/openj9#14531.

@vsebe vsebe force-pushed the openj9_criu branch 3 times, most recently from 2f6c1d0 to ecd1300 Compare April 13, 2022 15:18
@sxa
Copy link
Member

sxa commented Jul 1, 2022

@vsebe Can you confirm the answers to these questions from earlier please:

Is this needed during the build when configured with --enable-criu-support, the normal testing cycles, or only when attempting to use the CRIU functionality?

Also a couple of extra points:

  1. Ubuntu 16 is out of support - is that still required? There have been two new LTS releases since 18 and they are not covered here. We have a wide set of test platforms that won't have anything installed by the role - is that ok?
  2. This role is not being called by the top level main.yml in this PR. Is that intentional (i.e. are you calling it elsewhere in your setup of the OpenJ9 project's machines?

@sxa sxa added this to the 2022-07 (July) milestone Jul 1, 2022
@sxa sxa assigned vsebe Jul 1, 2022
@vsebe
Copy link
Contributor Author

vsebe commented Jul 6, 2022

Is this needed during the build when configured with --enable-criu-support, the normal testing cycles, or only when attempting to use the CRIU functionality?

Yes to all. It is required for building and testing OpenJ9 with criu support for JDK11+. Criu support for build is enabled with --enable-criu-support configure option. There are new sanity.functional tests enabled for our nightly pipelines. So far we enabled it only for linux x86, other linux platforms to be enabled later (see eclipse-openj9/openj9#14531 for further details).

  1. Ubuntu 16 is out of support - is that still required? There have been two new LTS releases since 18 and they are not covered here. We have a wide set of test platforms that won't have anything installed by the role - is that ok?

We still have Ubuntu16 machines on openj9-jenkins. This PR addresses 16, 18 and 20.
I will add 22 shortly.
The role should not run on your machines since it is not added to the AdoptOpenJDK_Unix_Playbook/main.yml.

  1. This role is not being called by the top level main.yml in this PR. Is that intentional (i.e. are you calling it elsewhere in your setup of the OpenJ9 project's machines?

Yes, it is. We have a different top level playbook for the IBM machines.

@sxa fyi

@vsebe vsebe force-pushed the openj9_criu branch 2 times, most recently from af0d2c6 to b3ddb6f Compare July 7, 2022 14:09
Add role to install CRIU on CentOS/RHEL 7 and Ubuntu.
Required by OpenJ9.
Related: eclipse-openj9/openj9#14016

Signed-off-by: Violeta Sebe <[email protected]>
@vsebe
Copy link
Contributor Author

vsebe commented Jul 7, 2022

I updated the task for Ubuntu 22.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is. We have a different top level playbook for the IBM machines.

On that basis I'm ok with it. Thanks for all the clarifications on the above points too - good to know :-) As long as we continue to build without --enable-criu-support it shouldn't affect us then.

@sxa sxa merged commit d4e293a into adoptium:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants