Add CRIU support system property #14270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JasonFengJ9 @pshipton please review |
JasonFengJ9
reviewed
Jan 13, 2022
| /*[IF CRIU_SUPPORT]*/ | ||
| initializedProperties.put("org.eclipse.openj9.criu.isCRIUCapable", "true"); //$NON-NLS-1$ //$NON-NLS-1$ | ||
| /*[ELSE] CRIU_SUPPORT | ||
| initializedProperties.put("org.eclipse.openj9.criu.isCRIUCapable", "false"); //$NON-NLS-1$ //$NON-NLS-1$ |
There was a problem hiding this comment.
I would hope any app/test assume org.eclipse.openj9.criu.isCRIUCapable is false if the system property is not set, then there is no need to set it false explicitly.
There was a problem hiding this comment.
Its not set. Its just that it will return null. If @llxia is fine with that then I can remove the else case.
There was a problem hiding this comment.
I guess Lan will have to deal with the NULL case anyways, for JDKs that dont have this property at all so Ill just remove it.
JasonFengJ9
reviewed
Jan 13, 2022
| @@ -618,6 +618,10 @@ private static void ensureProperties(boolean isInitialization) { | |||
| initializedProperties.put("java.specification.name", "Java Platform API Specification"); //$NON-NLS-1$ //$NON-NLS-2$ | |||
| initializedProperties.put("com.ibm.oti.configuration", "scar"); //$NON-NLS-1$ | |||
|
|
|||
| /*[IF CRIU_SUPPORT]*/ | |||
| initializedProperties.put("org.eclipse.openj9.criu.isCRIUCapable", "true"); //$NON-NLS-1$ //$NON-NLS-1$ | |||
There was a problem hiding this comment.
nitpick: //$NON-NLS-2$ is for second NLS comment.
Related to eclipse-openj9#14016 Signed-off-by: Tobi Ajila <[email protected]>
pshipton
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CRIU support system property
Related to #14016
Signed-off-by: Tobi Ajila [email protected]