refactor: fix checkstyle errors #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelSteinert checks are failing, can to take a look? |
|
@juliapampus The entire project structure has changed in this branch, so that the Git workflows refer to non-existent files. Therefore, the pipelines fail. |
paullatzelsperger
requested changes
Mar 28, 2024
| @@ -91,7 +91,7 @@ | |||
| ], | |||
| "body": { | |||
| "mode": "raw", | |||
| "raw": "{\n \"@context\": {\n \"odrl\": \"http://www.w3.org/ns/odrl/2/\"\n },\n \"@type\": \"PolicyDefinitionRequestDto\",\n \"@id\": \"require-membership\",\n \"policy\": {\n \"@type\": \"http://www.w3.org/ns/odrl/2/Set\",\n \"odrl:permission\": [\n {\n \"odrl:action\": \"use\",\n \"odrl:constraint\": {\n \"@type\": \"LogicalConstraint\",\n \"odrl:or\": [\n {\n \"@type\": \"Constraint\",\n \"odrl:leftOperand\": \"MembershipCredential\",\n \"odrl:operator\": {\n \"@id\": \"odrl:eq\"\n },\n \"odrl:rightOperand\": \"active\"\n }\n ]\n }\n }\n ]\n }\n}" | |||
| "raw": "{\n \"@context\": {\n \"odrl\": \"http://www.w3.org/ns/odrl/2/\"\n },\n \"@type\": \"PolicyDefinitionRequestDto\",\n \"@id\": \"require-membership\",\n \"policy\": {\n \"@type\": \"http://www.w3.org/ns/odrl/2/Set\",\n \"odrl:permission\": [\n {\n \"odrl:action\": \"use\",\n \"odrl:constraint\": {\n \"@type\": \"LogicalConstraint\",\n \"odrl:leftOperand\": \"MembershipCredential\",\n \"odrl:operator\": {\n \"@id\": \"odrl:eq\"\n },\n \"odrl:rightOperand\": \"active\"\n }\n }\n ]\n }\n}" | |||
There was a problem hiding this comment.
No reason to change the postman collection in a PR that deals with checkstyle. If there was a problem/bug, your PR description should clearly explain what you fixed and why.
It's virtually impossible to discern that from the diff.
There was a problem hiding this comment.
okay. i have removed it.
If the CI fails, that is fine, no worries. |
This reverts commit de6d7e6.
paullatzelsperger
approved these changes
Mar 28, 2024
paullatzelsperger
merged commit 71daac5
into
eclipse-edc:mvd-with-iatp
5 of 8 checks passed
paullatzelsperger
added a commit
that referenced
this pull request
Jul 4, 2024
* fix checksytle errors * fixed postman collection * code cleanup * missing pods added * Revert "fixed postman collection" This reverts commit de6d7e6. * Removed unnecessary linebreaks --------- Co-authored-by: Paul Latzelsperger <[email protected]>
paullatzelsperger
added a commit
that referenced
this pull request
Jul 8, 2024
* feat: minimal mvd variant with IATP * update gradle * add keypair mgmt api * updated collection * added wrapper jar * updated collection * update run configs * change namespace * updated mgmt api collection * adapt to latest ih changes * upgrade docker image to temurin 21 * seed participant to IH * update seeding, remove BPN reformat some files, update seeding script, use DID as identifier everywhere * update seed again, fix scope extractor * WIP - do not use * feat: improvements to seeding VCs prepared distinction between DID documents used for running locally, vs running on a cluster * wip * load credentials from the filesystem * update README * feat: add seeding ext. for super-user There is a new module "inmem-seeding" which creates the super-user. Exclude this module if database persistence is used to avoid conflicts. * update run configs * alice now has a Membership Cred in JWT Format * use Hashicorp Vault as secret store * fixed postman collection * upgrade to EDC 0.6.0-SNAPSHOT * register missing transformer * refactor: fix checkstyle errors (#239) * fix checksytle errors * fixed postman collection * code cleanup * missing pods added * Revert "fixed postman collection" This reverts commit de6d7e6. * Removed unnecessary linebreaks --------- Co-authored-by: Paul Latzelsperger <[email protected]> * update to latest EDC * update to EDC 0.6.1 * feat: add script to sign existing VCs * re-add participant pem files * add ALG parameter (wip) * go back to PEM for now * fix formatting * fixed K8S variant * update to EDC 0.6.5-SNAPSHOT * adapt to EDC 0.7.1-SNAPSHOT * refactoring, renaming, improving dependencies * Fix credentials, rename packages, add catalog (local only, no k8s yet!) * upgrade K8S deployment with catalog * add auxiliary seed script * documentation, cleanup * move code from runtimes/ into root folder * add catalog server runtime * update runtime names * move out catalog node resolver * add seeding for the catalog server * moved connector DCP patches out * renamed modules * add federatedcatalog API * bump EDC * updated README with mangaement domains scenario * replaced IATP -> DCP * TF: add catalog server as standalone deployment (wip) * TF: one vault per consumer/provider * fix k8s seed * TF: add documentation * feat: add PG persistence (#269) * add consumer pg * add consumer DB seed script * add all provider databases + seed scripts * Add PG modules (wip) * improve postgres initialization * add IH persistence * change build flag * remove old workflows * terraform format * update README * feat: rename alice->consumer and bob->provider * license headers * formatting * merge tf checks * setup build in workflow * remove unnecessary parameter * fix tests --------- Co-authored-by: Michael Steinert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
this PR: