Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade MVD with DCP and Management Domains #270

Merged
merged 66 commits into from
Jul 8, 2024

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR brings a completely new iteration of the MinimumViableDataspace project by adding the following high-level features:

  • DCP: support for the Decentralized Claims Protocol and VerifiableCredentials
  • Dataplane Signaling
  • Management Domains
  • Simplification: several bits and pieces have been hacked off to make it sleek and simple, namely:
    • cloud resources: no more Azure/AWS/etc. resources being provisioned, data transfers possible via HTTP
    • static participant list: instead of a dedicated RegistrationService, we are using a static file that contains participant addresses
    • MVD can be run and debugged easily from within IntelliJ
    • Kubernetes deployment: MVD will also come with a turnkey Kubernetes deployment setup

Why it does that

Keep up with current developments, improve the developer experience

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files should have an updated header: 2023 --> 2024

@paullatzelsperger paullatzelsperger force-pushed the mvd-with-dcp-and-mgmtdomains branch from 1de7714 to 8c6ad8a Compare July 4, 2024 14:49
@paullatzelsperger paullatzelsperger force-pushed the mvd-with-dcp-and-mgmtdomains branch from 8c6ad8a to 68ee636 Compare July 4, 2024 14:52
@paullatzelsperger
Copy link
Member Author

New files should have an updated header: 2023 --> 2024

those files have been there for quite some time, only in a different branch. but technically, they were in the repo, since the branch was in the upstream.

@paullatzelsperger paullatzelsperger force-pushed the mvd-with-dcp-and-mgmtdomains branch from 69e98df to f49c3a8 Compare July 4, 2024 15:00
@paullatzelsperger paullatzelsperger force-pushed the mvd-with-dcp-and-mgmtdomains branch from f49c3a8 to b9ce172 Compare July 4, 2024 15:08
@paullatzelsperger paullatzelsperger force-pushed the mvd-with-dcp-and-mgmtdomains branch from 369f2b9 to 6175851 Compare July 4, 2024 15:19
@paullatzelsperger paullatzelsperger requested a review from man8pr July 5, 2024 05:11
@paullatzelsperger paullatzelsperger force-pushed the mvd-with-dcp-and-mgmtdomains branch from f2f0a11 to d652e37 Compare July 5, 2024 05:19
@harnvo
Copy link

harnvo commented Jul 5, 2024

I tried running the demo via IntelliJ and resulted in the following errors:

For Connector Consumer Corp I have:

SEVERE 2024-07-05T15:37:24.168402714 Error booting runtime: No setting found for key edc.mvd.credentials.path
org.eclipse.edc.spi.EdcException: No setting found for key edc.mvd.credentials.path

For IdentityHub Consumer Corp I have:

SEVERE 2024-07-05T15:30:41.8848147 Error booting runtime: No setting found for key edc.mvd.participants.list.file
org.eclipse.edc.spi.EdcException: No setting found for key edc.mvd.participants.list.file

For Provider Catalog Server I have:

SEVERE 2024-07-05T15:30:42.160374888 Error booting runtime: No setting found for key edc.mvd.credentials.path
org.eclipse.edc.spi.EdcException: No setting found for key edc.mvd.credentials.path

@paullatzelsperger
Copy link
Member Author

paullatzelsperger commented Jul 5, 2024

@harnvo something is fishy there. The catalog server and the connectors should not need the edc.mvd.credentials.path, and in turn the IdentityHub should not need the participants list. There is something weird going on.

In any event, I could not reproduce the errors you describe. If you're on Windows, be aware that paths may be a problem, and we don't officially support running this natively on Windows. We typically recommend using WSL.

@harnvo
Copy link

harnvo commented Jul 5, 2024

@paullatzelsperger I am using wsl2.

I later tried reproducing the problem in my Debian PC but everything works fine. It seems something's wrong on the WSL's side.

@paullatzelsperger
Copy link
Member Author

@paullatzelsperger I am using wsl2.

I later tried reproducing the problem in my Debian PC but everything works fine. It seems something's wrong on the WSL's side.

this is just the run configurations, so nothing critical, but it still detracts from developer experience. if you are open to investigating platform-independent run configs, we'd welcome a PR

@harnvo
Copy link

harnvo commented Jul 5, 2024

this is just the run configurations, so nothing critical, but it still detracts from developer experience. if you are open to investigating platform-independent run configs, we'd welcome a PR

I would take a look when I am available.

The two PCs I have uses different network proxies, so it is also possible that one of the maven mirror did not update the package in-time.

Just curious: have eclipse-edc updated some packages recently? In this case waiting for a few days should solve the problem.

Copy link
Contributor

@man8pr man8pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Intellij

@paullatzelsperger
Copy link
Member Author

Just curious: have eclipse-edc updated some packages recently? In this case waiting for a few days should solve the problem.

we publish snapshot builds on every PR merge, but you can force the refresh by either appending --refresh-dependencies to your gradle command, or by deleting your local gradle and maven caches.

@harnvo
Copy link

harnvo commented Jul 8, 2024

Update: I eventually find out what happened.

Somehow Intellij did not read the configuration in .run properly, and I have to manually edit the module config with UI to match the actual configuration file. After this everthing could work properly.

The problem would presist if I re-clone this repo. But I would stop the investigation since this is something wrong with Intellij (probably the IDE is somehow corrupted), and that I could not reproduce the problem in another windows PC (which has the same windows version, wsl version, Intellij version and the same proxy).

@paullatzelsperger
Copy link
Member Author

@harnvo thanks a lot for investigating!

@paullatzelsperger paullatzelsperger merged commit f2ce6f2 into main Jul 8, 2024
6 checks passed
@paullatzelsperger paullatzelsperger deleted the mvd-with-dcp-and-mgmtdomains branch July 8, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants