-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce impact of ApiColorPicker emit bug #4328
Reduce impact of ApiColorPicker emit bug #4328
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't fix the bug - it must makes it a bit harder to get the timing right in order to reproduce 😄
Recording.2023-12-26.191728.mp4
To me this smells like a wrong handling of dirty data.
- outside value should not override local data if local data is dirty
- outside value should not trigger an API call
@usu I agree, sadly the colorpicker always emits when the input value doesn't match the exact VColorPicker color object (which is never). This would need a wrapper component to encapsulate the colorpicker. |
@usu I couldn't easily fix the picker problem. I did manage to prevent an api request if the value changes from the outside. I think we could fix the dirty problem in a separate PR. |
@usu I think my PR already provides a real improvement. Could you have a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The experience is better than before.
For most users it will be enough
Use default autoSaveDelay to fix #4212