Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong dirty handling for ApiColorPicker #4404

Closed
usu opened this issue Jan 8, 2024 · 1 comment
Closed

Wrong dirty handling for ApiColorPicker #4404

usu opened this issue Jan 8, 2024 · 1 comment

Comments

@usu
Copy link
Member

usu commented Jan 8, 2024

          @usu I couldn't easily fix the picker problem. I did manage to prevent an api request if the value changes from the outside. I think we could fix the dirty problem in a separate PR.

Originally posted by @manuelmeister in #4328 (comment)

Problem not a problem with ApiColorPicker but either with BasePicker or with ApiWrapper in general.

The dirty handling has also been raised in the following issues, so it probably makes sense to look at it more holistically:

@carlobeltrame
Copy link
Member

Fixed in #4761 (unless someone manages to reproduce still)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants