Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve admin activity section #4362

Merged

Conversation

manuelmeister
Copy link
Member

To simplify the process of creating and editing activity related admin settings, I've improved the category properties and category template as well as the progress labels.

This PR supersedes #4348 and #4182

localhost_3000_camps_3c79b99ab424_GRGR_category_a023e85227ac_Lagersport
localhost_3000_camps_3c79b99ab424_GRGR_category_a023e85227ac_Lagersport (1)

@manuelmeister manuelmeister added type: Frontend UX/UI deploy! Creates a feature branch deployment for this PR External feedback This Issue is Based on Feedback from the Community labels Dec 31, 2023
Copy link

github-actions bot commented Dec 31, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looks very good.
Found some issues.

Thank you

@manuelmeister
Copy link
Member Author

@BacLuc you can have a look again.

@BacLuc
Copy link
Contributor

BacLuc commented Jan 2, 2024

Now that the ApiColorPicker is not in the dialog anymore, the problem in #4328 is better visible.
Screencast from 02.01.2024 10:35:26.webm
When you load the dialog, we have an unnecessary patch request.

@pmattmann
Copy link
Member

I like it! 🚀

One question:
Is it intentional that the ContentNodes are not centered in paper-size mode?
In the activity, the content is displayed centered. I would vote to make this consistent.

@manuelmeister
Copy link
Member Author

@pmattmann thanks for the feedback. I wasn't satisfied either, thanks for pushing me to perfection ;)
I moved it to the ContentCard just like in the activity view. It looks much cleaner.

@manuelmeister manuelmeister added this pull request to the merge queue Jan 4, 2024
Merged via the queue into ecamp:devel with commit 965b3f7 Jan 4, 2024
32 checks passed
@manuelmeister manuelmeister deleted the feature/admin-activity-improve branch January 4, 2024 17:57
Copy link

sentry-io bot commented Jan 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading '_meta') categoryRoute(src/router) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR External feedback This Issue is Based on Feedback from the Community type: Frontend UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants