Use release env for release github workflow #2608
Conversation
WalkthroughThe pull request modifies the workflow file Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/protocol-release.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.3)
.github/workflows/protocol-release.yml
123-123: this step is for running shell command since it contains at least one of "run", "shell" keys, but also contains "with" key which is used for running action
(syntax-check)
125-125: unexpected key "secrets" for "step" section. expected one of "continue-on-error", "env", "id", "if", "name", "run", "shell", "timeout-minutes", "uses", "with", "working-directory"
(syntax-check)
🔇 Additional comments (1)
.github/workflows/protocol-release.yml (1)
Line range hint 182-183: LGTM: Version formatting follows semantic versioning
The sed command correctly transforms the version format to comply with semantic versioning specification for pre-release versions (e.g., 1.0.1-rc1 → 1.0.1-rc.1).
🧰 Tools
🪛 actionlint (1.7.3)
123-123: this step is for running shell command since it contains at least one of "run", "shell" keys, but also contains "with" key which is used for running action
(syntax-check)
125-125: unexpected key "secrets" for "step" section. expected one of "continue-on-error", "env", "id", "if", "name", "run", "shell", "timeout-minutes", "uses", "with", "working-directory"
(syntax-check)
| with: | ||
| ENVIRONMENT: release | ||
| secrets: inherit |
There was a problem hiding this comment.
Fix incorrect workflow syntax for environment configuration
The current syntax is invalid and will cause the workflow to fail. The with and secrets keys are incorrectly placed at the step level without a corresponding action or command. These configurations should be at the job level.
Apply this fix:
v4-proto-py-release:
runs-on: ubuntu-latest
+ environment: release
+ secrets: inherit
defaults:
run:
working-directory: ./v4-proto-py
- with:
- ENVIRONMENT: release
- secrets: inherit📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| with: | |
| ENVIRONMENT: release | |
| secrets: inherit | |
| v4-proto-py-release: | |
| runs-on: ubuntu-latest | |
| environment: release | |
| secrets: inherit | |
| defaults: | |
| run: | |
| working-directory: ./v4-proto-py |
🧰 Tools
🪛 actionlint (1.7.3)
123-123: this step is for running shell command since it contains at least one of "run", "shell" keys, but also contains "with" key which is used for running action
(syntax-check)
125-125: unexpected key "secrets" for "step" section. expected one of "continue-on-error", "env", "id", "if", "name", "run", "shell", "timeout-minutes", "uses", "with", "working-directory"
(syntax-check)
…#2626) (#2627) Co-authored-by: jayy04 <[email protected]>
Changelist
Created a separate env for github release workflow. Only applicable to python
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
VERSIONvariable during updates.