Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use release env for release github workflow (#2608)" #2626

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jayy04
Copy link
Contributor

@jayy04 jayy04 commented Dec 6, 2024

This reverts commit 744a58b.

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Enhanced release process for different protocols, including support for standard, release candidate, and development versions.
    • Automatic versioning and packaging for Go, Python, and JavaScript protocols.
    • Streamlined creation of GitHub releases with compressed binaries and published packages.
  • Bug Fixes

    • Improved consistency in version handling across various protocols.

@jayy04 jayy04 requested a review from a team as a code owner December 6, 2024 20:34
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in the pull request focus on modifying the .github/workflows/protocol-release.yml file to improve the release process for various protocols. The workflow is triggered by specific tag pushes, and it includes organized steps for setting the version, installing Go, building and compressing binaries, and creating GitHub releases. Additionally, updates were made to the v4-proto-py-release and v4-proto-js-release jobs to ensure consistent version handling and proper publishing of packages.

Changes

File Change Summary
.github/workflows/protocol-release.yml Enhanced release process with structured steps for versioning, building binaries, and creating releases. Updates for v4-proto-py-release and v4-proto-js-release jobs to manage versions and publish packages.

Possibly related PRs

  • Revert "Disable arm release build" #1712: This PR modifies the .github/workflows/protocol-release.yml file to enhance the build process for creating reproducible binaries, which is directly related to the changes made in the main PR regarding the release process for protocols.
  • Use release env for release github workflow #2608: This PR also updates the .github/workflows/protocol-release.yml file, focusing on environment management and version handling, which aligns with the main PR's objective of streamlining the release process.

🐰 In the meadow, a rabbit did hop,
With releases so smooth, we’ll never stop!
Binaries bundled, versions in line,
Our protocols ready, oh how they shine!
With each little tag, a new joy we find,
Hooray for the changes, so perfectly timed! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ab98dd4 and b6d005d.

📒 Files selected for processing (1)
  • .github/workflows/protocol-release.yml (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jayy04 jayy04 merged commit 8c7d85f into main Dec 6, 2024
5 checks passed
@jayy04 jayy04 deleted the jy/revert-release-flow branch December 6, 2024 20:35
@jayy04
Copy link
Contributor Author

jayy04 commented Dec 6, 2024

@Mergifyio backport release/protocol/v8.x

Copy link
Contributor

mergify bot commented Dec 6, 2024

backport release/protocol/v8.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants