Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release env for release github workflow #2608

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Use release env for release github workflow #2608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/protocol-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ jobs:
TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
run: |
twine upload -r pypi dist/*
with:
ENVIRONMENT: release
secrets: inherit
Comment on lines +123 to +125
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix incorrect workflow syntax for environment configuration

The current syntax is invalid and will cause the workflow to fail. The with and secrets keys are incorrectly placed at the step level without a corresponding action or command. These configurations should be at the job level.

Apply this fix:

  v4-proto-py-release:
    runs-on: ubuntu-latest
+   environment: release
+   secrets: inherit
    defaults:
      run:
        working-directory: ./v4-proto-py
-   with:
-     ENVIRONMENT: release
-   secrets: inherit
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
with:
ENVIRONMENT: release
secrets: inherit
v4-proto-py-release:
runs-on: ubuntu-latest
environment: release
secrets: inherit
defaults:
run:
working-directory: ./v4-proto-py
🧰 Tools
🪛 actionlint (1.7.3)

123-123: this step is for running shell command since it contains at least one of "run", "shell" keys, but also contains "with" key which is used for running action

(syntax-check)

125-125: unexpected key "secrets" for "step" section. expected one of "continue-on-error", "env", "id", "if", "name", "run", "shell", "timeout-minutes", "uses", "with", "working-directory"

(syntax-check)


v4-proto-js-release:
runs-on: ubuntu-latest
Expand Down