Update CI for new Python versions #234
Conversation
|
Why is pylint giving an incorrect error on the freaking typing module (
But from typing import Any, Callable, cast, Dict, Optional, TypeVarAnd it's been subscriptable since at least 3.5: https://docs.python.org/3.5/library/typing.html#typing.Optional |
|
Looks like this is pylint-dev/pylint#3882 A fix has been merged on October 9th: pylint-dev/pylint#3890 However, there has not been a Pylint release since then, because of other outsanding Python 3.9-specific bugs. |
|
I think the easiest fix is to fully separate testing and linting, instead of having the test task also do linting on every platform. |
|
@nbraud i'm pushing a change that should fix this by only using pylint and mypy in the linter task. |
|
As a bonus, it gets rid of that kludgey |
|
Okay, at this point:
Those are the only failures. I'll throw together a fix for the pylint one (by not running the linter) now. |
Yay! I had issues with that in #233 too :3 |
235: Fix CI r=nbraud a=nbraud
- [x] Stop running lints when running tests.
Not only is this inefficient, it forces us to get linting working in all
environments, which isn't currently possible (see pylint-dev/pylint#3882).
As a result, remove the `_test-only` task.
- [x] Don't run tests when bootstrapping Bork in CI
- It is useless, as `python3 /tmp/bork...pyz run test` immediately shells
out to pytest, and tests the version of bork that is on the filesystem.
- It fails because `git` isn't installed.
Changes by @duckinator and myself, extracted from #233 and #234
Co-authored-by: Ellen Marie Dash <[email protected]>
Co-authored-by: nicoo <[email protected]>
|
I folded the CI-fixing changes in another PR, and rebased this branch :) |
|
@duckinator This works now, and I updated I would suggest setting only “bors” as a required CI step, so we don't have to manually keep the Github repo config in sync with |
|
I set GitHub up to only require bors. 👍 Long-term, I have a rough idea for a nicer way to configure CI stuff — see #236 for details. |
|
@duckinator Thanks! <3 Is this good to merge? |
|
Rebased to squish the With those changes in, I believe this PR is good to go. |
|
@nbraud this is good to merge. 🙂 |
|
bors r+ |
That's blocked on the
setuptoolsport being updated to build for 3.9