Switch to using `build` (instead of `pep517`) #233

nbraud · 2020-12-28T16:58:09Z

No description provided.

nbraud · 2020-12-28T17:03:00Z

@duckinator I ran the tests, and it builds one of my local projects without issue.
I also built bork as a zipapp (using itself, of course) and used the zipapp to rebuild bork and my project.

nbraud · 2020-12-28T17:20:08Z

I'm confused why the linting fails in the Zippapp bootstrap (and only then) ; I don't even see where does the import-order linter come from, let alone whether it is erroneously treating build as if it was part of the standard distribution.

duckinator · 2020-12-28T23:03:12Z

The current pylint setup is to enable everything, and disable what we don't want. I'm okay adding wrong-import-order to the list of disabled ones — I rarely find it useful. https://github.com/duckinator/bork/blob/master/.pylintrc#L21-L27

Also: the zipapp kludge is still needed, unfortunately, because the build library uses the pep517 library internally. We don't actually get rid of the pep517 dependency, we just get a better API to work with.

duckinator · 2020-12-28T23:04:03Z

@nbraud I'd say try reverting the commit removing the zipapp kludge and work from there.

nbraud · 2020-12-30T01:44:42Z

Also: the zipapp kludge is still needed, unfortunately, because the build library uses the pep517 library internally. We don't actually get rid of the pep517 dependency, we just get a better API to work with.

Oh sadness xD
I guess it only worked because I was testing in an environment where pep517 was installed.

nbraud · 2020-12-30T01:46:48Z

PS: Looks like the erroneous lint still triggers in the boopstrat tests.

duckinator · 2020-12-30T02:11:23Z

You can go ahead and add wrong-import-order to the list of disabled checkers here: https://github.com/duckinator/bork/blob/master/.pylintrc#L21-L27

I honestly thought I'd disabled it at some point. Must've been another project. 😛

nbraud · 2020-12-30T09:42:04Z

OK, it looks like there are a few things going on:

FreeBSD and macOS have a legit test failure: error: invalid command 'bdist_wheel' when building ppb_mutant
Is this because wheel isn't installed?
The zipapp bootstrap fails on linting, with an erroneous lint.

nbraud · 2020-12-30T18:34:41Z

@duckinator Could you look into the breakage on macOS? I don't have any Apple devices to test with :3

duckinator · 2020-12-30T22:36:10Z

@nbraud looks like we're running into pypa/build#108. Looks like the tl;dr is it's a resolved setuptools bug, and pinning setuptools>42 in pyproject.toml:

requires = ["setuptools > 42", "wheel"]

(We did similar with Emanate ages ago, for different reasons, in duckinator/emanate/pull/136)

@duckinator

235: Fix CI r=nbraud a=nbraud - [x] Stop running lints when running tests. Not only is this inefficient, it forces us to get linting working in all environments, which isn't currently possible (see pylint-dev/pylint#3882). As a result, remove the `_test-only` task. - [x] Don't run tests when bootstrapping Bork in CI - It is useless, as `python3 /tmp/bork...pyz run test` immediately shells out to pytest, and tests the version of bork that is on the filesystem. - It fails because `git` isn't installed. Changes by @duckinator and myself, extracted from #233 and #234 Co-authored-by: Ellen Marie Dash <[email protected]> Co-authored-by: nicoo <[email protected]>

Using pep517 through its CLI entrypoint is not recommended. Closes: #197

Otherwise, binary wheel packages cannot be built.

This is necessary, as `build` otherwise fails on macOS.

Older versions are buggy on macOS; see pypa/build#108

nbraud · 2021-01-01T19:07:01Z

Looks like version constraints in pyproject.toml's build-system.requires are silently ignored. It's ridiculous that, in 20 fucking 21, none of the Python tooling actually obeys version constraints, but it's somewhat out-of-scope for Bork to fix. >_>'

For now, I kicked in a setup step on macOS that updates pip and setuptools. I guess I should do that on all platforms, just to be sure?

Obsolete setuptools was the cause of a CI bug on macOS, see previous commit.

duckinator · 2021-01-02T02:11:13Z

It's ridiculous that, in 20 fucking 21, none of the Python tooling actually obeys version constraints

I know that pip is working on fixing this problem on their side. It was part of their big rewrite of the resolver, iirc.

I'll investigate and see if I can find what exact thing is responsible for ignoring the version here.

duckinator · 2021-01-02T02:14:14Z

For now, I kicked in a setup step on macOS that updates pip and setuptools. I guess I should do that on all platforms, just to be sure?

In theory we should be able to get away with just updating pip, which is probably good practice anyway. But yeah, since it's giving us problems, let's install new setuptools as well.

duckinator · 2021-01-02T02:44:45Z

Opened pypa/pip#9416 about being unable to pin requirement versions in pyproject.toml.

nbraud · 2021-01-02T12:28:47Z

Opened pypa/pip#9416 about being unable to pin requirement versions in pyproject.toml.

From the discussion there, it looks like pip honors the version constraints, but the projects being built in tests need that version constraint (for their build to succeed on macOS)

If you can reproduce the issue locally (I do not have a macOS box to test with), could you confirm that setuptools > 42 is sufficient to fix the issue? I can then go add the version constraint everywhere it's needed.

This reverts commit 9e3efc1.

duckinator · 2021-01-03T00:13:12Z

@nbraud I do not have access to a mac, so can only reproduce it in CI. I'm not entirely sure how to approach this, tbh.

nbraud · 2021-01-03T20:28:13Z

@nbraud I do not have access to a mac, so can only reproduce it in CI. I'm not entirely sure how to approach this, tbh.

Oh, OK.

I'd suggest merging this anyhow, since the issue is shown to be outside of bork and the tests are working. Maybe we can enlist @AstraLuma's help to get this confirmed and fixed in the other projects?

duckinator · 2021-01-03T21:04:34Z

@nbraud sounds like a plan to me. merge when you think it's ready. 👍

nbraud · 2021-01-03T21:26:52Z

bors r=duckinator

bors · 2021-01-03T21:48:18Z

Build succeeded:

nbraud force-pushed the build branch from 9a9f4a2 to 0d22c9f Compare December 28, 2020 17:09

nbraud force-pushed the build branch 3 times, most recently from c4878a8 to 5c7e01a Compare December 30, 2020 12:41

This was referenced Jan 1, 2021

Update CI for new Python versions #234

Merged

Fix CI #235

Merged

builder: Replace library pep517 with build

a91860c

Using pep517 through its CLI entrypoint is not recommended. Closes: #197

nbraud force-pushed the build branch from 5c7e01a to df850b8 Compare January 1, 2021 17:51

nbraud added 2 commits January 1, 2021 18:53

setup.cfg: Make wheel an explicit dependency

084f48b

Otherwise, binary wheel packages cannot be built.

builder.dist: Create the output directory before building

9e3efc1

This is necessary, as `build` otherwise fails on macOS.

nbraud force-pushed the build branch from df850b8 to 9e3efc1 Compare January 1, 2021 17:53

Require setuptools 42 or later to build Bork

cd95def

Older versions are buggy on macOS; see pypa/build#108

nbraud force-pushed the build branch from f899d31 to cd95def Compare January 1, 2021 18:58

CI: Update pip and setuptools on all platforms before doing anything

45bb864

Obsolete setuptools was the cause of a CI bug on macOS, see previous commit.

Revert "builder.dist: Create the output directory before building"

b471896

This reverts commit 9e3efc1.

bors bot merged commit 6d2c896 into master Jan 3, 2021

bors bot deleted the build branch January 3, 2021 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to using `build` (instead of `pep517`) #233

Switch to using `build` (instead of `pep517`) #233

nbraud commented Dec 28, 2020

nbraud commented Dec 28, 2020

nbraud commented Dec 28, 2020

duckinator commented Dec 28, 2020

duckinator commented Dec 28, 2020

nbraud commented Dec 30, 2020

nbraud commented Dec 30, 2020

duckinator commented Dec 30, 2020

nbraud commented Dec 30, 2020

nbraud commented Dec 30, 2020

duckinator commented Dec 30, 2020

nbraud commented Jan 1, 2021

duckinator commented Jan 2, 2021 •

edited

Loading

duckinator commented Jan 2, 2021 •

edited

Loading

duckinator commented Jan 2, 2021

nbraud commented Jan 2, 2021 •

edited

Loading

duckinator commented Jan 3, 2021

nbraud commented Jan 3, 2021

duckinator commented Jan 3, 2021

nbraud commented Jan 3, 2021

bors bot commented Jan 3, 2021

Switch to using build (instead of pep517) #233

Switch to using build (instead of pep517) #233

Conversation

nbraud commented Dec 28, 2020

nbraud commented Dec 28, 2020

nbraud commented Dec 28, 2020

duckinator commented Dec 28, 2020

duckinator commented Dec 28, 2020

nbraud commented Dec 30, 2020

nbraud commented Dec 30, 2020

duckinator commented Dec 30, 2020

nbraud commented Dec 30, 2020

nbraud commented Dec 30, 2020

duckinator commented Dec 30, 2020

nbraud commented Jan 1, 2021

duckinator commented Jan 2, 2021 • edited Loading

duckinator commented Jan 2, 2021 • edited Loading

duckinator commented Jan 2, 2021

nbraud commented Jan 2, 2021 • edited Loading

duckinator commented Jan 3, 2021

nbraud commented Jan 3, 2021

duckinator commented Jan 3, 2021

nbraud commented Jan 3, 2021

bors bot commented Jan 3, 2021

Switch to using `build` (instead of `pep517`) #233

Switch to using `build` (instead of `pep517`) #233

duckinator commented Jan 2, 2021 •

edited

Loading

duckinator commented Jan 2, 2021 •

edited

Loading

nbraud commented Jan 2, 2021 •

edited

Loading