Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate better bors/GitHub integration? #236

Closed
duckinator opened this issue Jan 2, 2021 · 1 comment · Fixed by #237
Closed

Investigate better bors/GitHub integration? #236

duckinator opened this issue Jan 2, 2021 · 1 comment · Fixed by #237

Comments

@duckinator
Copy link
Owner

duckinator commented Jan 2, 2021

Follow-up to #234.

My idea is, basically:

  1. Have a Cirrus CI task named something like "CI_Success_task", which does nothing but relies on all other CI tasks.
  2. Have bors rely on just that task.

This lets us have all the CI-related configuration that's prone to changing over time in one place.

@nbraud: what are your thoughts on this approach?

@nbraud
Copy link
Collaborator

nbraud commented Jan 2, 2021

3 main thoughts:

  1. I already find .cirrus.yml just large enough to be annoying to navigate, so it's actually slightly more convenient when editing the set of tasks Bors waits on to have it in bors.toml.
  2. If we use an alias in each task definition (to captures all instances for all versions of Python we test against), then editing that set would be much, much less frequent and error-prone.
  3. Reversing the relationship (i.e. having a depended_on_by on each relevant task, rather than a depends_on list in the CI_Success_task) would be even better, but I don't think the Cirrus config language supports that.

👍 from me overall

bors bot added a commit that referenced this issue Jan 3, 2021
237: Define “success” as a single CI task, refactor Bors & release config r=duckinator a=nbraud

- [x] Introduced aliases for each task group
- [x] Introduced a “CI success” task that depends on all relevant tasks
- [x] Refactored the Bors config and release task to depend on that task

Closes #236

Co-authored-by: nicoo <[email protected]>
bors bot added a commit that referenced this issue Jan 4, 2021
237: Define “success” as a single CI task, refactor Bors & release config r=duckinator a=nbraud

- [x] Introduced aliases for each task group
- [x] Introduced a “CI success” task that depends on all relevant tasks
- [x] Refactored the Bors config and release task to depend on that task

Closes #236

Co-authored-by: nicoo <[email protected]>
@bors bors bot closed this as completed in b800d2c Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants