Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2493 develop aeronet3 lat lon elv #2495

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Mar 30, 2023

Expected Differences

Little different fix than 11.0 bugfix. Some codes in first line checking are moved to out of while loop.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:
bin/ascii2nc /d1/projects/METplus/discussions/1888/Discussion1888/20230309.lev15 test_aeronet.nc -format aeronetv3
python3 scripts/utility/print_pointnc2ascii.py test_aeronet.nc | awk ' {print $4, $5, $6, $2;}' | uniq -c | less

Result (the lat/lon for GSFC should be different from Tucson)

   <count> <lat> <lon> <elv> <SiteName>
   3752 32.2330 -110.9530 779.0000 Tucson
   4536 38.9925 -76.8398 87.0000 GSFC
   2072 25.7320 -80.1633 10.0000 Key_Biscayne
   ...
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

The unit test exists already

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

Different lat/lon/elv at aeronet/20221202.v3.lev15.nc

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 11.1.0 milestone Mar 30, 2023
@hsoh-u hsoh-u requested a review from jprestop March 30, 2023 20:05
@hsoh-u hsoh-u linked an issue Mar 30, 2023 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u I have reviewed the code changes and confirm that only expected changes in the output were found:

file2: /data/output/met_test_output/aeronet/20221202.v3.lev15.nc
ERROR: found   104 differences in var hdr_elv                                - max abs: 769 
ERROR: found   104 differences in var hdr_lat                                - max abs: 15.5005 
ERROR: found   104 differences in var hdr_lon                                - max abs: 88.0175 

Thank you for your work on this task! I approve this request.

@hsoh-u hsoh-u merged commit d91165c into develop Mar 30, 2023
@hsoh-u hsoh-u deleted the bugfix_2493_dev_aeronet3_lat_lon_elv branch March 30, 2023 21:17
@JohnHalleyGotway JohnHalleyGotway changed the title #2493 updates lat/lon/elv if SiteName is changed Bugfix #2493 develop aeronet3 lat lon elv Mar 30, 2023
JohnHalleyGotway added a commit that referenced this pull request Mar 31, 2023
Co-authored-by: johnhg <[email protected]>
Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: John Halley Gotway <[email protected]>
Co-authored-by: Dave Albo <[email protected]>
Co-authored-by: MET Tools Test Account <[email protected]>
Co-authored-by: Howard Soh <[email protected]>
Co-authored-by: Jonathan Vigh <[email protected]>
Co-authored-by: jprestop <[email protected]>
Co-authored-by: Seth Linden <[email protected]>
Co-authored-by: hsoh-u <[email protected]>
Co-authored-by: davidalbo <[email protected]>
Co-authored-by: lisagoodrich <[email protected]>
Co-authored-by: George McCabe <[email protected]>
Co-authored-by: Daniel Adriaansen <[email protected]>
Co-authored-by: Lisa Goodrich <[email protected]>
fix #2309 develop tcmpr (#2310)
fix #2306 ascii2nc airnow hourly (#2314)
fix_spread_md (#2335)
fix #2389 develop flowchart (#2392)
Fix Python environment issue (#2407)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406)
fix #2380 develop override (#2382)
fix #2408 develop empty config (#2410)
fix #2390 develop compile zlib (#2404)
fix #2412 develop climo (#2422)
fix #2437 develop convert (#2439)
fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix #2452 develop airnow (#2454)
fix #2449 develop pdf (#2464)
fix #2402 develop sonarqube (#2468)
fix #2426 develop buoy (#2475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bugfix: AERONET the lat/lon is not changed with different station ID
2 participants