Bugfix: Address MET-11.0.0 SonarQube Blocker Bugs

[JohnHalleyGotway]

Describe the Problem

The SonarQube scan of the MET-11.0.0 released code flagged several issues with bugs with a blocker status. This results in an error status of the scan. Recommend addressing these issues ASAP and resolving them in a MET-11.0.1 bugfix release. Fix any issues that can be addressed directly. Document justification for any issues that cannot be fixed directly.

See the nightly SonarQube scans: http://mandan.rap.ucar.edu:9000
Also see the Excel and Word summaries:
2023-01-11-MET Nightly build-issues-report.xlsx
2023-01-11-MET Nightly build-analysis-report.docx

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2771021

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Organization level Project for support of the current coordinated release
• Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy
  None.

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Organization level software support Project for the current coordinated release
  Select: Milestone as the next bugfix version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Development issue
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Close this issue.

[JohnHalleyGotway]

Doing development on seneca. Rerun a SonarQube scan with:

cd /d1/personal/johnhg/MET/MET_development/bugfix_2402
./run.sh

Inspect SonarQube run output on mandan (inside firewall).

As of 2/15/23, the 100 bugs are broken down as:

[JohnHalleyGotway]

Commit f882d97 reduced the bugs from 100 to 99, and reduced the blockers from 22 to 21.

[JohnHalleyGotway]

After the changes so far today, my 22 Blocker bugs are now down to 10. Yeah!