Feature #2633 seeps default p1 threshold (#2634)

* Update develop-ref after #2555 and #2561 (#2568) Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: Seth Linden <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Daniel Adriaansen <[email protected]> Co-authored-by: John and Cindy <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: Seth Linden <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: davidalbo <[email protected]> Co-authored-by: Lisa Goodrich <[email protected]> Co-authored-by: metplus-bot <[email protected]> Co-authored-by: j-opatz <[email protected]> Fix Python environment issue (#2407) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406) fix #2380 develop override (#2382) fix #2408 develop empty config (#2410) fix #2390 develop compile zlib (#2404) fix #2412 develop climo (#2422) fix #2437 develop convert (#2439) fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix #2452 develop airnow (#2454) fix #2449 develop pdf (#2464) fix #2402 develop sonarqube (#2468) fix #2426 develop buoy (#2475) fix 2518 dtypes appf docs (#2519) fix 2531 compilation errors (#2533) fix #2531 compilation_errors_configure (#2535) * Per #2582, update unit_plot_tc.xml to use the -save_data option. * modified the config for mode regarding multivar_intensity_flag * #2633 Set the default seeps_p1_thresh to >=0.1&&<=0.85 * #2633 Added default setting of seeps_p1_thresh * Per #2633, small tweaks to the config file comments and documentation --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: metplus-bot <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: David Albo <[email protected]> Co-authored-by: Howard Soh <[email protected]>
dtcenter · Jul 31, 2023 · 4137ccb · 4137ccb
1 parent cea2839
commit 4137ccb
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 17 deletions.
diff --git a/data/config/GridStatConfig_default b/data/config/GridStatConfig_default
@@ -207,6 +207,13 @@ distance_map = {
 
 ////////////////////////////////////////////////////////////////////////////////
 
+//
+// Threshold for SEEPS p1 (Probability of being dry)
+//
+seeps_p1_thresh = >=0.1&&<=0.85;
+
+////////////////////////////////////////////////////////////////////////////////
+
 //
 // Statistical output types
 // May be set separately in each "obs.field" entry
@@ -255,11 +262,6 @@ nc_pairs_flag = {
    apply_mask   = TRUE;
 }
 
-////////////////////////////////////////////////////////////////////////////////
-// Threshold for SEEPS p1 (Probability of being dry)
-
-seeps_p1_thresh = NA;
-
 ////////////////////////////////////////////////////////////////////////////////
 
 grid_weight_flag = NONE;

diff --git a/data/config/PointStatConfig_default b/data/config/PointStatConfig_default
@@ -261,6 +261,13 @@ hira = {
 
 ////////////////////////////////////////////////////////////////////////////////
 
+//
+// Threshold for SEEPS p1 (Probability of being dry)
+//
+seeps_p1_thresh = >=0.1&&<=0.85;
+
+////////////////////////////////////////////////////////////////////////////////
+
 //
 // Statistical output types
 // May be set separately in each "obs.field" entry
@@ -290,10 +297,6 @@ output_flag = {
    seeps_mpr = NONE;
 }
 
-////////////////////////////////////////////////////////////////////////////////
-// Threshold for SEEPS p1 (Probability of being dry)
-
-seeps_p1_thresh = NA;
 ////////////////////////////////////////////////////////////////////////////////
 
 tmp_dir        = "/tmp";

diff --git a/docs/Users_Guide/config_options.rst b/docs/Users_Guide/config_options.rst
@@ -1471,7 +1471,7 @@ all pairs into a single climatological bin.
      direct_prob = FALSE; or TRUE
   }
 
-climato_data
+climate_data
 ^^^^^^^^^^^^
 
 When specifying climatology data for probability forecasts, either supply a
@@ -1499,13 +1499,15 @@ In this way, the number of bins impacts the resolution of the climatological
 probabilities. These derived probability values are used to compute the
 climatological Brier Score and Brier Skill Score.
 
+seeps_p1_thresh
+^^^^^^^^^^^^^^^
 
 The "seeps_p1_thresh" option controls the threshold of p1 (probability of being dry) values.
+The default setting is >=0.1&&<=0.85.
 
 .. code-block:: none
-		
-  seeps_p1_thresh = >=0.1&&<=0.85;
 
+  seeps_p1_thresh = >=0.1&&<=0.85;
 
 mask_missing_flag
 ^^^^^^^^^^^^^^^^^

diff --git a/internal/test_unit/xml/unit_plot_tc.xml b/internal/test_unit/xml/unit_plot_tc.xml
@@ -23,13 +23,15 @@
       -lookin &OUTPUT_DIR;/tc_pairs/alal2010.tcst \
       -filter '-amodel AHWI,BCLP' \
       -outdir &OUTPUT_DIR;/plot_tc \
-      -dep 'TK_ERR,ABS(AMAX_WIND-BMAX_WIND)'
+      -dep 'TK_ERR,ABS(AMAX_WIND-BMAX_WIND)' \
+      -save_data &OUTPUT_DIR;/plot_tc/plot_tc_TCMPR_data.tcst
     </param>
     <output>
-      <exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.png</exist> 
-      <exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.log</exist> 
-      <exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.png</exist> 
-      <exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.log</exist> 
+      <exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.png</exist>
+      <exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.log</exist>
+      <exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.png</exist>
+      <exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.log</exist>
+      <stat>&OUTPUT_DIR;/plot_tc/plot_tc_TCMPR_data.tcst</stat>
     </output>
   </test>