Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: AERONET the lat/lon is not changed with different station ID #2493

Closed
22 tasks
hsoh-u opened this issue Mar 28, 2023 · 0 comments · Fixed by #2494, #2495, #2498 or #2499
Closed
22 tasks

Bugfix: AERONET the lat/lon is not changed with different station ID #2493

hsoh-u opened this issue Mar 28, 2023 · 0 comments · Fixed by #2494, #2495, #2498 or #2499
Assignees
Labels
MET: PreProcessing Tools (Point) priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Mar 28, 2023

Replace italics below with details for this issue.

Describe the Problem

The AREONET version 3 has a variation of 6 line header which has lat/lon/elv columns. The lat/lon/elv should be updated when the SiteName is changed: "Tucson 32.233002 -110.953003 779" to "GSFC 38.9925 -76.839833 87"

The command at seneca:

/d1/projects/MET/MET_regression/develop/NB20230328/MET-develop/bin/ascii2nc /d1/projects/METplus/discussions/1888/Discussion1888/20230309.lev15 test_aeronet.nc -format aeronetv3

The AREONET input

AERONET_Site_Name	Site_Latitude(Degrees)	Site_Longitude(Degrees)	Site_Elevation(m)
Tucson	32.233002	-110.953003	779
Tucson	32.233002	-110.953003	779
Tucson	32.233002	-110.953003	779
GSFC	38.9925		-76.839833	 87
GSFC	38.9925		-76.839833	 87

The output of print_pointnc2ascii.py shows the same lat/lon/elv of "Tucson" for "GSFC"

AERONET_AOD Tucson	20230309_235841 32.2330 -110.9530 779 AOD	NA  550.00 NA    0.02957695
AERONET_AOD GSFC	20230309_121903 32.2330 -110.9530 779 AOD	NA 1640.00 NA    0.00589800
AERONET_AOD GSFC	20230309_121903 32.2330 -110.9530 779 AOD	NA 1020.00 NA    0.01574700

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

The output of print_pointnc2ascii.py should be:

AERONET_AOD Tucson	20230309_235841 32.2330 -110.9530 779 AOD	NA  550.00 NA    0.02957695
AERONET_AOD GSFC	20230309_121903 38.9925  -76.8398  87 AOD	NA 1640.00 NA    0.00589800
AERONET_AOD GSFC	20230309_121903 38.9925  -76.8398  87 AOD	NA 1020.00 NA    0.01574700

Environment

Describe your runtime environment:
1. Machine: Linux Workstation, seneca
2. OS: RedHat Linux
3. Software version number(s): MET v11.0 and v11.1

To Reproduce

Describe the steps to reproduce the behavior:

  1. bin/ascii2nc /d1/projects/METplus/discussions/1888/Discussion1888/20230309.lev15 test_aeronet.nc -format aeronetv3
  2. <MET_BASE>/utility/print_pointnc2ascii.py test_aeronet.nc > dump_aeronet.txt
  3. Check the lat/lon/elv of Tucson and GSFC

Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@hsoh-u hsoh-u added type: bug Fix something that is not working alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 28, 2023
@hsoh-u hsoh-u added this to the MET 11.0.2 (bugfix) milestone Mar 28, 2023
@hsoh-u hsoh-u self-assigned this Mar 28, 2023
@jprestop jprestop moved this from 📋 Backlog to 🔖 Ready in MET-11.1.0 Development Mar 28, 2023
@jprestop jprestop moved this from 📋 Backlog to 🔖 Ready in Coordinated METplus-5.0 Support Mar 28, 2023
@JohnHalleyGotway JohnHalleyGotway added requestor: NOAA/EMC NOAA Environmental Modeling Center priority: blocker Blocker MET: PreProcessing Tools (Point) and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 29, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 🏗 In progress in MET-11.1.0 Development Mar 29, 2023
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 🏗 In progress in Coordinated METplus-5.0 Support Mar 29, 2023
hsoh-u pushed a commit that referenced this issue Mar 30, 2023
@hsoh-u hsoh-u linked a pull request Mar 30, 2023 that will close this issue
15 tasks
@hsoh-u hsoh-u moved this from 🏗 In progress to 👀 In review in Coordinated METplus-5.0 Support Mar 30, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Coordinated METplus-5.0 Support Mar 30, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in MET-11.1.0 Development Mar 30, 2023
@hsoh-u hsoh-u linked a pull request Mar 30, 2023 that will close this issue
15 tasks
hsoh-u added a commit that referenced this issue Mar 30, 2023
…on_elv

#2493 updates lat/lon/elv if SiteName is changed
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Mar 31, 2023
This was linked to pull requests Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment