Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor .env files and suggest usage #351

Merged
merged 4 commits into from
Mar 16, 2018
Merged

Honor .env files and suggest usage #351

merged 4 commits into from
Mar 16, 2018

Conversation

weitzman
Copy link
Contributor

@weitzman weitzman commented Feb 9, 2018

No description provided.

@weitzman weitzman mentioned this pull request Mar 4, 2018
Open
This was referenced Mar 12, 2018
Closed
Closed
@webflo webflo merged commit 1665375 into 8.x Mar 16, 2018
@webflo webflo deleted the DotEnv branch March 16, 2018 21:40
@webflo
Copy link
Member

webflo commented Mar 16, 2018

Thanks @weitzman this is a great addition especially the DRUSH_OPTIONS_URI trick. 👍

@sharique
Copy link

This is really good feature, can we have some documentation, like how we can use these files for deployment?

@weitzman
Copy link
Contributor Author

Deployment is very site specific and I cant think of any generic docs we can add for it. Do you have anything in mind?

@sharique
Copy link

sharique commented Mar 29, 2018 •
edited
Loading

Let's say I've created 1 .env file for each environment (like .env.local and .env.dev etc..),
So what other steps I need to perform before running "composer install", so that based on environment I get updated settings.php file ready to use. Or what additional parameter I need to pass to "composer install " so that it can generate appropriate settings.php.

@weitzman
Copy link
Contributor Author

weitzman commented Mar 29, 2018 •
edited
Loading

composer install only downloads your codebase. It doesn't install drupal. Thats a one time step, unlike composer install/update.

You edit your settings.php by hand to add calls to getenv(). See this PR for examples.

seth-shaw-unlv pushed a commit to islandora-deprecated/drupal-project that referenced this pull request May 29, 2018
@dannylamb @seth-shaw-unlv
Merge from upstream, fix scaffolding issue (#18)
16c9bda 
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Composer lock from PHP 5.6

* Removing drupal-scaffold from the post-* commands
daften pushed a commit to district09/drupal8_project_template that referenced this pull request Aug 9, 2018
Merge remote-tracking branch 'upstream/8.x' into 8.x
25a97be 
* upstream/8.x: (22 commits)
  Remove unused use statement. (drupal-composer#406)
  Fix typo in README.md
  Remove "drupal-scaffold" from scripts (drupal-composer#275)
  Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)
  Fix tests on Travis CI (drupal-composer#405)
  Update drupal-composer/drupal-scaffold
  Fix installer path for drush commandfiles.
  Bump minimal version to 8.5.3
  Bump minimal version
  Updated argument name
  Remove extra whitespace (drupal-composer#371)
  Honor .env files and suggest usage (drupal-composer#351)
  Improve update instructions (drupal-composer#366)
  Run tests with 8.6.x
  Update to Drupal 8.5
  Add platform version to FAQ to help user specifying PHP version, fixes drupal-composer#359. (drupal-composer#360)
  Update /drush dir for Drush9 (drupal-composer#350)
  Revert "Update /drush dir for Drush9"
  Update /drush dir for Drush9
  Replace require-dev with webflo/drupal-core-require-dev (drupal-composer#348)
  ...

# Conflicts:
#	.gitignore
#	composer.json
#	drush/policy.drush.inc
Natkeeran pushed a commit to islandora-deprecated/drupal-project that referenced this pull request Sep 17, 2018
@dannylamb @Natkeeran
Drupal 8.6 (#23)
51a5785 
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Updating lock file

* Adding drupal-scaffold back in so it works with a lockfile

* drupal-scaffold is now @composer drupal:scaffold
whikloj pushed a commit to islandora-deprecated/drupal-project that referenced this pull request May 24, 2019
@Natkeeran @whikloj
Drupal 8.7 (#27)
b354ba7 
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Require zaporylie/composer-drupal-optimizations (drupal-composer#442)

* Issue drupal-composer#408: Bump minimum PHP version to 5.6

* Removing redundant "--stability dev" from installation command (drupal-composer#450)

Fixes drupal-composer#449.

* Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420)

* Sync new lines at the end of the files (drupal-composer#453)

* Quote wildcards to avoid issues in some shells (drupal-composer#456)

* Add PHP 7.3 to Travis CI (drupal-composer#476)

* Change createRequiredFiles messages to reflect what occured (drupal-composer#467)

* Drop PHP 5.6 testing (drupal-composer#489)

* Bump minimum version to 8.7.0 (drupal-composer#488)

* Update .travis.yml

* update composer.lock
@wxactly wxactly mentioned this pull request Dec 13, 2019
Merged
dannylamb pushed a commit to islandora-deprecated/drupal-project that referenced this pull request Jan 2, 2020
@elizoller @weitzman
@zaporylie @morenstrat @webflo @rodrigoaguilera @leymannx @milkovsky @mxr576 @grasmash @andypost @hansfn @MPParsley @petk @gagarine @foxtrotcharlie @greg-1-anderson @paulvandenburg @dannylamb
Update to Drupal 8.8.1 (#34)
b802bb3 
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Require zaporylie/composer-drupal-optimizations (drupal-composer#442)

* Issue drupal-composer#408: Bump minimum PHP version to 5.6

* Removing redundant "--stability dev" from installation command (drupal-composer#450)

Fixes drupal-composer#449.

* Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420)

* Sync new lines at the end of the files (drupal-composer#453)

* Quote wildcards to avoid issues in some shells (drupal-composer#456)

* Add PHP 7.3 to Travis CI (drupal-composer#476)

* Change createRequiredFiles messages to reflect what occured (drupal-composer#467)

* Drop PHP 5.6 testing (drupal-composer#489)

* Bump minimum version to 8.7.0 (drupal-composer#488)

* Update .travis.yml

* Deprecate PHP 7.0 and 7.1 (drupal-composer#518)

* Revert "Deprecate PHP 7.1" (drupal-composer#521)

This reverts commit 5085410.

* Issue drupal-composer#518: Bump minimum php version to 7.0.8

* Update CI to Ubuntu 18.04 (drupal-composer#520)

* Revert "Update CI to Ubuntu 18.04" (drupal-composer#526)

This reverts commit ee5bf36.

* Add 'contrib' to Drush commandfile installer path (drupal-composer#525)

* Prefer usage of && operator instead of "and" (drupal-composer#530)

* update to drupal 8.8.0

* replace webflo/drupal-core-require-dev with drupal/core-dev

* Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522)

* Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY

* update to 8.8.1

Co-authored-by: Moshe Weitzman <[email protected]>
Co-authored-by: Jakub Piasecki <[email protected]>
Co-authored-by: Markus Orenstrat <[email protected]>
Co-authored-by: Florian Weber <[email protected]>
Co-authored-by: Rodrigo <[email protected]>
Co-authored-by: Norman Kämper-Leymann <[email protected]>
Co-authored-by: Alex Milkovskyi <[email protected]>
Co-authored-by: Dezső BICZÓ <[email protected]>
Co-authored-by: Matthew Grasmick <[email protected]>
Co-authored-by: Andy Postnikov <[email protected]>
Co-authored-by: Hans Fredrik Nordhaug <[email protected]>
Co-authored-by: Maarten Segers <[email protected]>
Co-authored-by: Peter Kokot <[email protected]>
Co-authored-by: Simon Perdrisat <[email protected]>
Co-authored-by: Charles Tanton <[email protected]>
Co-authored-by: Greg Anderson <[email protected]>
Co-authored-by: Paul <[email protected]>
shrop pushed a commit to shrop/drupal-project that referenced this pull request Apr 11, 2020
@weitzman @shrop
Honor .env files and suggest usage (drupal-composer#351)
1c19e08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weitzman @webflo @sharique