Update /drush dir for Drush9 #350
Conversation
Shows how the benefits of a policyfile and also illustrates where to store site aliases and druh config.
| * Encourage folks to use `composer` instead of Drush pm commands | ||
| */ | ||
| function drush_policy_pm_updatecode_validate() { | ||
| return _deny_message(); |
There was a problem hiding this comment.
This functionality is not present in the replacement Drush\Commands\PolicyCommands - should we not continue to prevent this?
There was a problem hiding this comment.
There is no pm-updatecode anymore so no need. Of course people still use Drush8 but thsoe folks are generally not starting brand new projects. This project is a starter-kit so we dont have to worry about existing sites.
There was a problem hiding this comment.
Same for pm-update and pm-download ...
There was a problem hiding this comment.
Ah - I should have checked the repo, I just did a quick check on drushcommands.com !
|
I did some code-styles fixes on the policy file. |
drush/Commands/PolicyCommands.php
Outdated
| * | ||
| * @throws \Exception | ||
| */ | ||
| public function validateUpdateDb(CommandData $commandData) { |
There was a problem hiding this comment.
Lets remove the validateUpdateDb example. I think its to advanced. We could like to the example for more examples :) sqlSyncValidate and rsyncValidate is good enough.
drush/Sites/self.site.yml
Outdated
| # Edit or remove this file as needed. | ||
| # Docs at https://github.com/drush-ops/drush/blob/master/examples/example.site.yml | ||
|
|
||
| #live: |
There was a problem hiding this comment.
Lets use prod here. It should match with our default policy file
There was a problem hiding this comment.
drush/Sites/self.site.yml should be sites?. I looked through the drush code and should not find a instance with Sites.
|
Implemented review feedback. |
|
@weitzman Thanks! Sorry for the delay. |
…m-project * upstream/8.x: Improve update instructions (drupal-composer#366) Run tests with 8.6.x Update to Drupal 8.5 Add platform version to FAQ to help user specifying PHP version, fixes drupal-composer#359. (drupal-composer#360) Update /drush dir for Drush9 (drupal-composer#350) Revert "Update /drush dir for Drush9" Update /drush dir for Drush9 Replace require-dev with webflo/drupal-core-require-dev (drupal-composer#348) Bump drush version Replace GPL-2.0+ by GPL-2.0-or-later Run tests with 8.5.x (drupal-composer#329) Update README.md (drupal-composer#334) Update composer dependencies (drupal-composer#325) Declare compatibility with versions of Drush and CSS selector that are compatible with Drupal 8.4 and earlier. Added composer validate to CI. Update .travis.yml Update .travis.yml Add support for Drush 9 and Drupal 8.4
* upstream/8.x: (22 commits) Remove unused use statement. (drupal-composer#406) Fix typo in README.md Remove "drupal-scaffold" from scripts (drupal-composer#275) Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404) Fix tests on Travis CI (drupal-composer#405) Update drupal-composer/drupal-scaffold Fix installer path for drush commandfiles. Bump minimal version to 8.5.3 Bump minimal version Updated argument name Remove extra whitespace (drupal-composer#371) Honor .env files and suggest usage (drupal-composer#351) Improve update instructions (drupal-composer#366) Run tests with 8.6.x Update to Drupal 8.5 Add platform version to FAQ to help user specifying PHP version, fixes drupal-composer#359. (drupal-composer#360) Update /drush dir for Drush9 (drupal-composer#350) Revert "Update /drush dir for Drush9" Update /drush dir for Drush9 Replace require-dev with webflo/drupal-core-require-dev (drupal-composer#348) ... # Conflicts: # .gitignore # composer.json # drush/policy.drush.inc
Shows how the benefits of a policyfile and also illustrates where to store site aliases and druh config.