Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json to require latest stable version of Drupal #424

Merged
merged 3 commits into from
Sep 6, 2018

Conversation

grasmash
Copy link
Contributor

@grasmash grasmash commented Sep 5, 2018

I'd like to post the following instructions on the /download page on Drupal.org:

composer create-project drupal-composer/drupal-project:8.x-dev --stability dev --no-interaction

However, this will require drupal-project to provide the latest recommended version of Drupal so that it matches the download button.

I'd like to post the following instructions on the /download page on Drupal.org:

    composer create-project drupal-composer/drupal-project:8.x-dev --stability dev --no-interaction

However, this will require drupal-project to provide the latest recommended version of Drupal so that it matches the download button.
@grasmash grasmash changed the title Update composer.json Update composer.json to require latest stable version of Drupal Sep 5, 2018
@greg-1-anderson
Copy link
Collaborator

I agree that this is preferable. composer update should track the latest stable Drupal version by default.

@webflo webflo mentioned this pull request Sep 6, 2018
@hansfn
Copy link
Contributor

hansfn commented Sep 7, 2018

Maybe we should documented somewhere that drupal-composer/drupal-project no longer is locked to a specific minor version since we have replaced "drupal/core": "~x.y.z" with "drupal/core": "^x.y.z"

More importantly, it should be mentioned in the update section that people with existing projects have to make this change to drupal/core and webflo/drupal-core-require-dev manually.

@jonpugh
Copy link

jonpugh commented Sep 7, 2018

Note I submitted a PR to the README.md related to this... #423

daften added a commit to district09/drupal8_project_template that referenced this pull request Sep 10, 2018
…8.x-upstream

* '8.x' of github.com:drupal-composer/drupal-project:
  Update composer.json to require latest stable version of Drupal (drupal-composer#424)
  Bump minimum required composer-patches version to support default patch level (drupal-composer#410)
  Adjust default core patch level to -p2. (drupal-composer#418)

# Conflicts:
#	composer.json
Natkeeran pushed a commit to islandora-deprecated/drupal-project that referenced this pull request Sep 17, 2018
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Updating lock file

* Adding drupal-scaffold back in so it works with a lockfile

* drupal-scaffold is now @composer drupal:scaffold
whikloj pushed a commit to islandora-deprecated/drupal-project that referenced this pull request May 24, 2019
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Require zaporylie/composer-drupal-optimizations (drupal-composer#442)

* Issue drupal-composer#408: Bump minimum PHP version to 5.6

* Removing redundant "--stability dev" from installation command (drupal-composer#450)

Fixes drupal-composer#449.

* Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420)

* Sync new lines at the end of the files (drupal-composer#453)

* Quote wildcards to avoid issues in some shells (drupal-composer#456)

* Add PHP 7.3 to Travis CI (drupal-composer#476)

* Change createRequiredFiles messages to reflect what occured (drupal-composer#467)

* Drop PHP 5.6 testing (drupal-composer#489)

* Bump minimum version to 8.7.0 (drupal-composer#488)

* Update .travis.yml

* update composer.lock
dannylamb pushed a commit to islandora-deprecated/drupal-project that referenced this pull request Jan 2, 2020
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Require zaporylie/composer-drupal-optimizations (drupal-composer#442)

* Issue drupal-composer#408: Bump minimum PHP version to 5.6

* Removing redundant "--stability dev" from installation command (drupal-composer#450)

Fixes drupal-composer#449.

* Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420)

* Sync new lines at the end of the files (drupal-composer#453)

* Quote wildcards to avoid issues in some shells (drupal-composer#456)

* Add PHP 7.3 to Travis CI (drupal-composer#476)

* Change createRequiredFiles messages to reflect what occured (drupal-composer#467)

* Drop PHP 5.6 testing (drupal-composer#489)

* Bump minimum version to 8.7.0 (drupal-composer#488)

* Update .travis.yml

* Deprecate PHP 7.0 and 7.1 (drupal-composer#518)

* Revert "Deprecate PHP 7.1" (drupal-composer#521)

This reverts commit 5085410.

* Issue drupal-composer#518: Bump minimum php version to 7.0.8

* Update CI to Ubuntu 18.04 (drupal-composer#520)

* Revert "Update CI to Ubuntu 18.04" (drupal-composer#526)

This reverts commit ee5bf36.

* Add 'contrib' to Drush commandfile installer path (drupal-composer#525)

* Prefer usage of && operator instead of "and" (drupal-composer#530)

* update to drupal 8.8.0

* replace webflo/drupal-core-require-dev with drupal/core-dev

* Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522)

* Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY

* update to 8.8.1

Co-authored-by: Moshe Weitzman <[email protected]>
Co-authored-by: Jakub Piasecki <[email protected]>
Co-authored-by: Markus Orenstrat <[email protected]>
Co-authored-by: Florian Weber <[email protected]>
Co-authored-by: Rodrigo <[email protected]>
Co-authored-by: Norman Kämper-Leymann <[email protected]>
Co-authored-by: Alex Milkovskyi <[email protected]>
Co-authored-by: Dezső BICZÓ <[email protected]>
Co-authored-by: Matthew Grasmick <[email protected]>
Co-authored-by: Andy Postnikov <[email protected]>
Co-authored-by: Hans Fredrik Nordhaug <[email protected]>
Co-authored-by: Maarten Segers <[email protected]>
Co-authored-by: Peter Kokot <[email protected]>
Co-authored-by: Simon Perdrisat <[email protected]>
Co-authored-by: Charles Tanton <[email protected]>
Co-authored-by: Greg Anderson <[email protected]>
Co-authored-by: Paul <[email protected]>
shrop pushed a commit to shrop/drupal-project that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants