Resolve component governance bugs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
reviewed
Nov 11, 2021
Comment on lines
71
to
77
| "resolutions": { | ||
| "ejs": ">=3.1.6", | ||
| "immer": ">=9.0.6", | ||
| "url-parse": ">=1.5.0", | ||
| "lodash": ">=4.17.21", | ||
| "glob-parent": ">=5.1.2", | ||
| "set-value": "4.0.1" |
There was a problem hiding this comment.
Our templates use NPM, these don't do anything
There was a problem hiding this comment.
I apologize will, I'm in the middle of doing a dep update (the traditional way) myself, just want to make sure I don't waste your time.
wtgodbe
force-pushed
the
wtgodbe/CompgGov
branch
from
467f0b5 to
8428e98
Compare
wtgodbe
force-pushed
the
wtgodbe/CompgGov
branch
from
8428e98 to
ae77788
Compare
|
This is now a direct port of #31 (CC @pranavkm @mkArtakMSFT @javiercn) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should backport this to 6.0.