Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPA] Update SPA templates NPM dependencies #31

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Nov 11, 2021

Description

Updates our SPA template dependencies as part of our regular update schedule on patch releases. This update contains an update from Angular 12 to Angular 13.

The update to the angular version has been performed by automation with ng update.

Customer Impact

Templates contain a set of fixed package versions that get regularly out of date and start producing security warnings. As part of our regular patch process we update these dependencies to keep our customers protected and make sure they don't have a bad experience due to security warnings appearing after project creation

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

We do this process regularly.

Verification

  • Manual (required)
  • Automated

Validated:

  • run Angular Individual auth on windows
  • run Angular no auth Individual auth on windows
  • run React Individual auth on windows
  • run React no auth on windows
  • Publish angular individual auth on Windows.
  • Publish react individual auth on Windows.

Updating package dependencies is not sensitive to OS issues.

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@javiercn javiercn changed the base branch from main to release/6.0 November 11, 2021 22:38
@javiercn javiercn marked this pull request as ready for review November 12, 2021 13:19
@javiercn javiercn requested a review from a team November 12, 2021 14:55
@wtgodbe
Copy link
Member

wtgodbe commented Nov 12, 2021

Can you port this to main also?

@javiercn
Copy link
Member Author

@wtgodbe will do. Wanted to make sure to get it in 6.0 first

@mkArtakMSFT
Copy link
Member

@wtgodbe I'm merging this now. Can you please make sure that we get this update through submodule update in aspnetcore ?

@wtgodbe
Copy link
Member

wtgodbe commented Nov 12, 2021

Will do

@mkArtakMSFT mkArtakMSFT merged commit 9ae11ce into release/6.0 Nov 12, 2021
@mkArtakMSFT mkArtakMSFT deleted the javiercn/update-npm-dependencies branch November 12, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants