Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Component Governance bugs #38310

Merged
merged 7 commits into from
Nov 13, 2021
Merged

Resolve Component Governance bugs #38310

merged 7 commits into from
Nov 13, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 11, 2021

Should resolve Component Governance bugs, except a couple that I'm following up on. Will want to take a submodule update once dotnet/spa-templates#30 is in.

CC @Pilchie

@wtgodbe wtgodbe requested review from dougbu, halter73, Tratcher and a team as code owners November 11, 2021 23:35
@@ -226,11 +226,11 @@
<MicrosoftAspNetCoreAzureAppServicesSiteExtension60x64Version>$(MicrosoftAspNetCoreAzureAppServicesSiteExtension60Version)</MicrosoftAspNetCoreAzureAppServicesSiteExtension60x64Version>
<MicrosoftAspNetCoreAzureAppServicesSiteExtension60x86Version>$(MicrosoftAspNetCoreAzureAppServicesSiteExtension60Version)</MicrosoftAspNetCoreAzureAppServicesSiteExtension60x86Version>
<!-- 3rd party dependencies -->
<AngleSharpVersion>0.9.9</AngleSharpVersion>
<AngleSharpVersion>0.10.0</AngleSharpVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file are to prevent System.Net.Http 4.1.0 from being brought in transitively

@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 12, 2021
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 12, 2021

Error: require() of ES Module D:\a_work\1\s\src\SignalR\clients\ts\common\node_modules\ansi-regex\index.js from D:\a_work\1\s\src\SignalR\clients\ts\common\node_modules\strip-ansi\index.js not supported.

@javiercn @captainsafia @pranavkm @BrennanConroy ansi-regex 5.0.0 was one of the components flagged by CompGov, but upgrading to 5.0.1 gives the above error - any ideas on what else I need to change?

@BrennanConroy
Copy link
Member

Try upgrading to 5.0.1 instead of 6.0.1

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 12, 2021

Hmm, looks like resolving >= 5.0.1 is bringing in 6.0.1. I'll ask for 5.0.1 exactly

Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wtgodbe wtgodbe enabled auto-merge (squash) November 12, 2021 22:19
@wtgodbe wtgodbe merged commit 13569cf into dotnet:main Nov 13, 2021
@ghost ghost added this to the 7.0-preview1 milestone Nov 13, 2021
@wtgodbe wtgodbe deleted the CompGov branch November 13, 2021 00:13
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 15, 2021

/backport to release/6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants