Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Clean-up typescript code imported from Blazor #89435

Merged
merged 67 commits into from
Jul 29, 2023
Merged

[browser] Clean-up typescript code imported from Blazor #89435

merged 67 commits into from
Jul 29, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Jul 25, 2023 •
edited
Loading

  • Removed features
    • downloadResource
    • withStartupOptions
    • getApplicationEnvironment
  • Blazor API dissolved to appropriate places
    • Removed blazor types
    • Removed integration layer
  • Rutime resources are split by behavior in boot config
    • Distinguishing them by behavior is moved to SDK. The future plan is define them as separate items in single place in MSBuild
  • Asset collection is replaced with ResourceGroups.
    • Internally still uses AssetEntry
    • Assets collection as input is still supported, but removed from dotnet.d.ts
  • Custom load boot resource is called for all resources
    • By default it is tried to be called by AssetBehaviors
    • If it doesn't provide a value, a WebAssemblyBootResourceType is used
  • Testing
    • Blazor E2E tests
    • Building and running .NET 7 Blazor app

Contributes to #70762

@maraf maraf added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jul 25, 2023
@maraf maraf added this to the 8.0.0 milestone Jul 25, 2023
@maraf maraf self-assigned this Jul 25, 2023
This was referenced Jul 25, 2023
Closed
Open
@pavelsavara pavelsavara mentioned this pull request Jul 26, 2023
Open
@maraf maraf marked this pull request as ready for review July 28, 2023 12:41
@maraf maraf requested review from radical, lewing and kg as code owners July 28, 2023 12:41
@maraf maraf requested a review from pavelsavara July 28, 2023 12:42
pavelsavara
pavelsavara reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I love it! 💙

src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonData.cs Show resolved Hide resolved
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs Outdated Show resolved Hide resolved
src/mono/wasm/Wasm.Build.Tests/TestMainJsProjectProvider.cs Outdated
@@ -22,8 +22,6 @@ public TestMainJsProjectProvider(ITestOutputHelper _testOutput, string? _project
protected override IReadOnlyDictionary<string, bool> GetAllKnownDotnetFilesToFingerprintMap(AssertBundleOptionsBase assertOptions)
=> new SortedDictionary<string, bool>()
{
{ "dotnet.js", false },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove dotnet.runtime.js.map ?

src/mono/wasm/runtime/loader/assetsCache.ts Outdated Show resolved Hide resolved
src/mono/wasm/runtime/loader/assets.ts Outdated Show resolved Hide resolved
src/mono/wasm/runtime/startup.ts Outdated Show resolved Hide resolved
src/mono/wasm/runtime/loader/assets.ts Outdated Show resolved Hide resolved
src/mono/wasm/runtime/loader/config.ts Show resolved Hide resolved
src/mono/wasm/runtime/loader/assets.ts Show resolved Hide resolved
src/mono/wasm/runtime/loader/assets.ts Outdated Show resolved Hide resolved
@pavelsavara
Copy link
Member

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member

I filled #89670 I think it's unrelated to this

This was referenced Jul 29, 2023
Closed
Closed
Closed
@pavelsavara pavelsavara merged commit 7a9ff69 into dotnet:main Jul 29, 2023
@SteveSandersonMS SteveSandersonMS mentioned this pull request Aug 1, 2023
Closed
radical added a commit to radical/runtime that referenced this pull request Aug 2, 2023
@radical
Revert "[browser] Clean-up typescript code imported from Blazor (dotn…
8aeabee 
…et#89435)"

This reverts commit 7a9ff69.
@maraf maraf deleted the WasmTsCleanUp branch August 14, 2023 07:42
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @pavelsavara