-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] V8 System.Text.Json.Tests AOT assert - loader.c:1821, condition not met #89670
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsError BlobBuild: https://dev.azure.com/dnceng-public/public/_build/results?buildId=356237&view=results {
"ErrorMessage": "loader.c:1821",
"BuildRetry": false,
"ExcludeConsoleLog": false
} Reproduction StepsV8 System.Text.Json.Tests AOT
|
Stack trace is possibly corrupted, because |
is also suspicious - do_jit_call transitioning to exit and then to AOT'd managed code is not possible. It looks like the thing called 'exit' here is a jit call wrapper (from jiterp), which would have a different name. So it seems like some sort of v8 bug may be producing incorrect stack traces here. |
I added some extra asserts and spent a while trying to reproduce this. My best guesses at this point are either memory corruption or GC (it's theoretically possible that while an interp_entry wrapper was queued for JIT compilation, the GC swept in and destroyed it. I don't know if this can actually happen.) |
Can't reproduce it either with the same seed. |
I've partially verified a theory: The S.T.J test suite ends up creating a bunch of temporary methods that then get GC'd, and right now jiterp does not handle the scenario where a MonoMethod gets freed. And the methods that are being freed do have jitted interp_entry wrappers, so it's quite possible that either:
|
I believe this is fixed and AFAIK we haven't seen it again, so closing. |
Error Blob
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=356237&view=results
Reproduction Steps
V8 System.Text.Json.Tests AOT, Log
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=356237
Error message validated:
loader.c:1821
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 7/29/2023 12:51:37 PM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: