-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] Clean-up typescript code imported from Blazor #89435
Merged
Merged
Changes from 48 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
e1c04bc
Remove assets from public monoConfig
maraf ddff687
Remove BootConfigResult.initAsync
maraf 1d9b6d3
Remove BootConfigResult
maraf 4677dda
Remove WebAssemblyResourceLoader
maraf d114b30
Fixes
maraf 5e8c364
Remove _Polyfill.ts
maraf ce5982f
Fix passing wrong instance of monoConfig by remove the function param…
maraf 9b98975
Remove withStartupOptions
maraf 3df841c
Remove getApplicationEnvironment
maraf 6e0e558
Use fetch_like for boot config with loadBootResource
maraf 7baa70d
Throw error when boot config doesn't contain resources
maraf a8f8d8c
Always use loadBootConfig
maraf ee3418a
Init resource cache after config is ready
maraf f912563
Revert test-main.js
maraf 726f4c8
Remove duplicated modifiableAssemblies and aspnetCoreBrowserTools
maraf 97b8eea
Don't read runtimeAssets
maraf 6c4bb33
Replace icuDataMode with globalizationMode
maraf c496c08
Replace assetsHash with resources.hash and compute has in WasmSDK
maraf cb3188f
Remove blazor.ts. Add configs to monoConfig. Produce mainAssemblyName…
maraf 86500c5
Replace manual config merging with deep_merge_config
maraf fe7f173
Ensure assets collection
maraf f876a67
Remove unused import
maraf 652e0ae
Fix deep_merge_config
maraf 41f7e38
Split runtime resources into groups by behavior in MSBuild
maraf 7d52aee
Use AssetBehaviours in resourceLoader
maraf 1177476
Use loadResource instead of hooking downloadResource
maraf cbed599
Update dotnet.d.ts
maraf 48cab75
Merge remote-tracking branch 'upstream/main' into WasmTsCleanUp
maraf dc19914
Fix WBT
maraf 3b58a64
Move config merge to loadBootConfig
maraf 5a82f25
Drop assemblyRootFolder
maraf 19a05d5
Read js-modules and wasm from resources
maraf 06e2de9
Read boot json assets in assets.ts
maraf fd3afb5
Fix wait_for_all_assets
maraf ea3daec
Split AssetBehaviors for single and all
maraf 4d68761
Make hash optional (+ compact schema)
maraf cfba71d
Revert test-main.js
maraf dfcbf4b
Fix appsettings
maraf 5bafb73
Fix enumerateResources
maraf 1082f1e
Renames
maraf 30136b2
Refactor hash computation and native resource distribution in SDK tasks
maraf c32f602
Drop commented code
maraf 7e998bb
Flatten structure of native resources and startup modules
maraf 1f67e01
Remove compact resource schema
maraf b30cb93
Use ResourceRequest in loadResource
maraf 317a96c
Fix WBT
maraf 1054b19
Drop unused isString
maraf 8d1eec8
Fix resource assemblies
maraf de7f74b
Rename config to appsettings
maraf e855052
Use more standard way to get URL and download asset
maraf f625263
Extract cache from resource loader. Move loading to assets
maraf d1f16e9
Rename resolve_asset_path to resolve_single_asset_path
maraf 1102ee3
Fix logDownloadStatsToConsole and purgeUnusedCacheEntriesAsync
maraf d04c549
Stop duplicating values to deprecated fields
maraf a87bd45
Use relaxed encoding and skip nulls
maraf 35c0ee4
Omit default values from boot config
maraf 3661d89
Unify resource name in boot config in Wasm SDk
maraf 40fc448
Fix reading pendingDownloadInternal in retrieve_asset_download
maraf 6a168ac
Fix retrieve_asset_download
maraf 81b79a6
Feedback
maraf d13807e
Pass AssetBehaviors to LoadBootResourceCallback, call it for everything
maraf ef7c8eb
Deep merge resources
maraf 79f2c42
Use System.Text.Json in GenerateWasmBootJson
maraf 9eda778
Merge remote-tracking branch 'upstream/main' into WasmTsCleanUp
maraf a9f7cf7
Order items when computing hash
maraf ed81e8e
Hotfix WBT
maraf 6b3712c
Fix WBT
maraf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radical I have removed
dotnet.js
from boot json, but it is expected to be present in the _framework. How would you prefer this method to be updated?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove
dotnet.runtime.js.map
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a hotfix to unblock WBT in this PR